device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc - Issue 1920693002: Complete //device/bt implementation for hosting local GATT attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

Issue 1920693002: Complete //device/bt implementation for hosting local GATT attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/fake_bluetooth_gatt_characteristic_service_provider.cc ('k') | device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_service_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

diff --git a/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc b/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

index c0dfc3b752c565f7d0f92ef4163a55cc4dbb5d21..88922dc505c65c9d78bbd9497a280cefc734bb47 100644

--- a/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

+++ b/device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.cc

@@ -4,8 +4,14 @@

#include "device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.h"

+#include <vector>

#include "base/bind.h"

+#include "base/callback.h"

+#include "base/callback_forward.h"

#include "base/logging.h"

+#include "dbus/bus.h"

+#include "dbus/property.h"

#include "device/bluetooth/dbus/bluetooth_gatt_characteristic_client.h"

#include "device/bluetooth/dbus/bluez_dbus_manager.h"

#include "third_party/cros_system_api/dbus/service_constants.h"

@@ -130,7 +136,7 @@ void FakeBluetoothGattDescriptorClient::WriteValue(

// Since the only fake descriptor is "Client Characteristic Configuration"

// and BlueZ doesn't allow writing to it, return failure.

- error_callback.Run("org.bluez.Error.NotPermitted",

+ error_callback.Run(bluetooth_gatt_service::kErrorWriteNotPermitted,

"Writing to the Client Characteristic Configuration "

"descriptor not allowed");

}