Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 1919763002: Migrate Object.definePropert{ies,y} from v8natives to builtins. (Closed)

Created:
4 years, 8 months ago by neis
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@v8natives
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate Object.definePropert{ies,y} from v8natives to builtins. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/0ff89ea75b3807d751c8cc7bb955a4325776de71 Cr-Commit-Position: refs/heads/master@{#35761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -121 lines) Patch
M src/bootstrapper.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/builtins.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +21 lines, -19 lines 0 comments Download
M src/js/array.js View 2 chunks +0 lines, -2 lines 0 comments Download
M src/js/i18n.js View 13 chunks +46 lines, -48 lines 0 comments Download
M src/js/messages.js View 3 chunks +3 lines, -5 lines 0 comments Download
M src/js/prologue.js View 2 chunks +4 lines, -5 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +0 lines, -20 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
neis
4 years, 8 months ago (2016-04-25 11:06:43 UTC) #1
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-25 11:14:52 UTC) #2
caitp (gmail)
Just a thought: if the pattern of moving things to builtins.cc continues, maybe it's worth ...
4 years, 8 months ago (2016-04-25 11:25:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919763002/1
4 years, 8 months ago (2016-04-25 11:44:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/16701) v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 8 months ago (2016-04-25 11:46:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1919763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1919763002/1
4 years, 8 months ago (2016-04-25 11:59:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 12:24:07 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 12:24:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ff89ea75b3807d751c8cc7bb955a4325776de71
Cr-Commit-Position: refs/heads/master@{#35761}

Powered by Google App Engine
This is Rietveld 408576698