Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1922453002: Migrate Object.getPrototypeOf from v8natives to builtins. (Closed)

Created:
4 years, 8 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Migrate Object.getPrototypeOf from v8natives to builtins. More v8natives cleanup to come... R=bmeurer@chromium.org BUG= Committed: https://crrev.com/17024be0773e13ea92359c1b7550193a8600834d Cr-Commit-Position: refs/heads/master@{#35759}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -26 lines) Patch
M src/bootstrapper.cc View 1 chunk +23 lines, -11 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/contexts.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/js/array.js View 3 chunks +5 lines, -3 lines 0 comments Download
M src/js/messages.js View 1 chunk +1 line, -1 line 0 comments Download
M src/js/v8natives.js View 3 chunks +2 lines, -10 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Issue 1919763002 Patch 1

Messages

Total messages: 7 (2 generated)
neis
4 years, 8 months ago (2016-04-25 09:36:04 UTC) #1
Benedikt Meurer
lgtm
4 years, 8 months ago (2016-04-25 11:15:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1922453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1922453002/1
4 years, 8 months ago (2016-04-25 11:16:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 11:44:19 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 11:45:50 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/17024be0773e13ea92359c1b7550193a8600834d
Cr-Commit-Position: refs/heads/master@{#35759}

Powered by Google App Engine
This is Rietveld 408576698