Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1918783002: Remove obsolete code from v8natives. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@v8natives-defineProperty
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove obsolete code from v8natives. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/dd5ccc8a774ec6bbe391818d41ee7268b47f0c0f Cr-Commit-Position: refs/heads/master@{#35763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -530 lines) Patch
M src/js/v8natives.js View 5 chunks +6 lines, -530 lines 0 comments Download

Depends on Patchset:

Issue 1919763002 Patch 1

Messages

Total messages: 7 (2 generated)
neis
4 years, 7 months ago (2016-04-25 12:05:21 UTC) #1
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-04-25 12:18:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1918783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1918783002/1
4 years, 7 months ago (2016-04-25 12:39:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-25 13:05:20 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-04-25 13:05:52 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dd5ccc8a774ec6bbe391818d41ee7268b47f0c0f
Cr-Commit-Position: refs/heads/master@{#35763}

Powered by Google App Engine
This is Rietveld 408576698