Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: src/js/prologue.js

Issue 1919763002: Migrate Object.definePropert{ies,y} from v8natives to builtins. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@v8natives
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/js/messages.js ('k') | src/js/v8natives.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/prologue.js
diff --git a/src/js/prologue.js b/src/js/prologue.js
index f9589a51c2fda9fe985a3953b889accbf117f4d8..7fe4383197b4fedf45bb54ee0ca94683fb553eb9 100644
--- a/src/js/prologue.js
+++ b/src/js/prologue.js
@@ -128,10 +128,10 @@ function InstallGetterSetter(object, name, getter, setter, attributes) {
function OverrideFunction(object, name, f, afterInitialBootstrap) {
%CheckIsBootstrapping();
- %ObjectDefineProperty(object, name, { value: f,
- writeable: true,
- configurable: true,
- enumerable: false });
+ %object_define_property(object, name, { value: f,
+ writeable: true,
+ configurable: true,
+ enumerable: false });
SetFunctionName(f, name);
if (!afterInitialBootstrap) %FunctionRemovePrototype(f);
%SetNativeFlag(f);
@@ -195,7 +195,6 @@ function PostNatives(utils) {
"MaxSimple",
"MinSimple",
"NumberIsInteger",
- "ObjectDefineProperty",
"ObserveArrayMethods",
"ObserveObjectMethods",
"PromiseChain",
« no previous file with comments | « src/js/messages.js ('k') | src/js/v8natives.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698