Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1917393002: [tools/perf] Reference legacy_page_test module instead of page_test (Closed)

Created:
4 years, 8 months ago by nednguyen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Reference legacy_page_test module instead of page_test BUG=606643 Committed: https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa Cr-Commit-Position: refs/heads/master@{#390176}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -81 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/dromaeo.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/dummy_benchmark.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/indexeddb_perf.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/jetstream.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/kraken.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/media.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/octane.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/oortonline.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/robohornet_pro.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/service_worker.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/spaceport.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/speedometer.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/sunspider.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/blink_style.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/draw_properties.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/image_decoding.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/measurement_smoke_test.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/media.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/memory.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/no_op.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/oilpan_gc_times.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/page_cycler.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/power.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/skpicture_printer.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/measurements/smoothness.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/startup.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/tab_switching.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/task_execution_time.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/thread_times.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/v8_detached_context_age_in_gc.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/v8_gc_times.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/webrtc.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/blob_workshop.py View 3 chunks +3 lines, -3 lines 0 comments Download
M tools/perf/page_sets/repaint_helpers.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
nednguyen
This triggers a bunch of PRESUBMIT warning which should be suppressed by https://codereview.chromium.org/1914233003/
4 years, 8 months ago (2016-04-27 04:37:45 UTC) #3
eakuefner
lgtm
4 years, 7 months ago (2016-04-27 11:48:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917393002/20001
4 years, 7 months ago (2016-04-27 14:14:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917393002/20001
4 years, 7 months ago (2016-04-27 16:04:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_cq/builds/141)
4 years, 7 months ago (2016-04-27 20:36:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917393002/20001
4 years, 7 months ago (2016-04-27 20:41:24 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-27 20:47:21 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:12:49 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e9321b1b00d13ce8833d5a434f5c1f3f675576fa
Cr-Commit-Position: refs/heads/master@{#390176}

Powered by Google App Engine
This is Rietveld 408576698