tools/perf/measurements/timeline_controller.py - Issue 1917393002: [tools/perf] Reference legacy_page_test module instead of page_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/timeline_controller.py

Issue 1917393002: [tools/perf] Reference legacy_page_test module instead of page_test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/timeline_controller.py

diff --git a/tools/perf/measurements/timeline_controller.py b/tools/perf/measurements/timeline_controller.py

index 93f29e3707d38a4e7d19643f3992d9aa40e542aa..07ac30364d5260abb2e3ffd5943173ae925fa4fa 100644

--- a/tools/perf/measurements/timeline_controller.py

+++ b/tools/perf/measurements/timeline_controller.py

@@ -2,7 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-from telemetry.page import page_test

+from telemetry.page import legacy_page_test

from telemetry.timeline.model import TimelineModel

from telemetry.timeline import tracing_config

from telemetry.value import trace

@@ -83,7 +83,7 @@ class TimelineController(object):

self._smooth_records = [run_smooth_actions_record]

if len(self._smooth_records) == 0:

- raise page_test.Failure('No interaction record was created.')

+ raise legacy_page_test.Failure('No interaction record was created.')

def CleanUp(self, platform):

if platform.tracing_controller.is_tracing_running:

« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | tools/perf/measurements/v8_detached_context_age_in_gc.py » ('j') | no next file with comments »