Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: tools/perf/measurements/measurement_smoke_test.py

Issue 1917393002: [tools/perf] Reference legacy_page_test module instead of page_test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/measurements/image_decoding.py ('k') | tools/perf/measurements/media.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import optparse 6 import optparse
7 import os 7 import os
8 import unittest 8 import unittest
9 9
10 from telemetry import benchmark as benchmark_module 10 from telemetry import benchmark as benchmark_module
11 from telemetry.core import discover 11 from telemetry.core import discover
12 from telemetry.internal.browser import browser_options 12 from telemetry.internal.browser import browser_options
13 from telemetry.page import page_test 13 from telemetry.page import legacy_page_test
14 from telemetry.testing import options_for_unittests 14 from telemetry.testing import options_for_unittests
15 from telemetry.web_perf import timeline_based_measurement 15 from telemetry.web_perf import timeline_based_measurement
16 16
17 17
18 def _GetAllPossiblePageTestInstances(): 18 def _GetAllPossiblePageTestInstances():
19 page_test_instances = [] 19 page_test_instances = []
20 measurements_dir = os.path.dirname(__file__) 20 measurements_dir = os.path.dirname(__file__)
21 top_level_dir = os.path.dirname(measurements_dir) 21 top_level_dir = os.path.dirname(measurements_dir)
22 benchmarks_dir = os.path.join(top_level_dir, 'benchmarks') 22 benchmarks_dir = os.path.join(top_level_dir, 'benchmarks')
23 23
24 # Get all page test instances from measurement classes that are directly 24 # Get all page test instances from measurement classes that are directly
25 # constructible 25 # constructible
26 all_measurement_classes = discover.DiscoverClasses( 26 all_measurement_classes = discover.DiscoverClasses(
27 measurements_dir, top_level_dir, page_test.PageTest, 27 measurements_dir, top_level_dir, legacy_page_test.LegacyPageTest,
28 index_by_class_name=True, directly_constructable=True).values() 28 index_by_class_name=True, directly_constructable=True).values()
29 for measurement_class in all_measurement_classes: 29 for measurement_class in all_measurement_classes:
30 page_test_instances.append(measurement_class()) 30 page_test_instances.append(measurement_class())
31 31
32 all_benchmarks_classes = discover.DiscoverClasses( 32 all_benchmarks_classes = discover.DiscoverClasses(
33 benchmarks_dir, top_level_dir, benchmark_module.Benchmark).values() 33 benchmarks_dir, top_level_dir, benchmark_module.Benchmark).values()
34 34
35 # Get all page test instances from defined benchmarks. 35 # Get all page test instances from defined benchmarks.
36 # Note: since this depends on the command line options, there is no guaranteed 36 # Note: since this depends on the command line options, there is no guaranteed
37 # that this will generate all possible page test instances but it's worth 37 # that this will generate all possible page test instances but it's worth
(...skipping 16 matching lines...) Expand all
54 page_test_instances.append(pt) 54 page_test_instances.append(pt)
55 55
56 return page_test_instances 56 return page_test_instances
57 57
58 58
59 class MeasurementSmokeTest(unittest.TestCase): 59 class MeasurementSmokeTest(unittest.TestCase):
60 # Simple smoke test to make sure that all page_test are constructible. 60 # Simple smoke test to make sure that all page_test are constructible.
61 61
62 def testAllMeasurementInstance(self): 62 def testAllMeasurementInstance(self):
63 _GetAllPossiblePageTestInstances() 63 _GetAllPossiblePageTestInstances()
OLDNEW
« no previous file with comments | « tools/perf/measurements/image_decoding.py ('k') | tools/perf/measurements/media.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698