tools/perf/page_sets/blob_workshop.py - Issue 1917393002: [tools/perf] Reference legacy_page_test module instead of page_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/blob_workshop.py

Issue 1917393002: [tools/perf] Reference legacy_page_test module instead of page_test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/page_sets/blob_workshop.py

diff --git a/tools/perf/page_sets/blob_workshop.py b/tools/perf/page_sets/blob_workshop.py

index 5e9efc76626f8dd1c055b01d4e9229e79867e48c..c6e6da6e48d71f51e50cb32657278ca11404530d 100644

--- a/tools/perf/page_sets/blob_workshop.py

+++ b/tools/perf/page_sets/blob_workshop.py

@@ -3,7 +3,7 @@

# found in the LICENSE file.

from telemetry.page import page as page_module

-from telemetry.page import page_test as page_test

+from telemetry.page import legacy_page_test

from telemetry import story

@@ -32,7 +32,7 @@ class BlobCreateThenRead(page_module.Page):

errors = action_runner.EvaluateJavaScript('errors')

if errors:

- raise page_test.Failure('Errors on page: ' + ', '.join(errors))

+ raise legacy_page_test.Failure('Errors on page: ' + ', '.join(errors))

class BlobMassCreate(page_module.Page):

@@ -65,7 +65,7 @@ class BlobMassCreate(page_module.Page):

errors = action_runner.EvaluateJavaScript('errors')

if errors:

- raise page_test.Failure('Errors on page: ' + ', '.join(errors))

+ raise legacy_page_test.Failure('Errors on page: ' + ', '.join(errors))

class BlobWorkshopPageSet(story.StorySet):

« no previous file with comments | « tools/perf/measurements/webrtc.py ('k') | tools/perf/page_sets/repaint_helpers.py » ('j') | no next file with comments »