Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 191723003: Nukes USE_AURA ifdefs from views (Closed)

Created:
6 years, 9 months ago by sky
Modified:
6 years, 9 months ago
CC:
chromium-reviews, msw+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, dcheng, alicet1, ben+views_chromium.org
Visibility:
Public.

Description

Nukes USE_AURA ifdefs from views No longer needed. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255976

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 12

Patch Set 3 : incorporate feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -470 lines) Patch
M ui/views/accessibility/native_view_accessibility_win_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/accessible_pane_view_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/background.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 8 chunks +3 lines, -15 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 1 chunk +6 lines, -10 lines 0 comments Download
M ui/views/controls/link.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ui/views/controls/menu/menu_config.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_config_win.cc View 2 chunks +1 line, -6 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ui/views/controls/menu/menu_host.cc View 3 chunks +1 line, -8 lines 0 comments Download
M ui/views/controls/menu/menu_host_root_view.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/controls/menu/menu_runner.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/views/controls/menu/menu_scroll_view_container.cc View 3 chunks +1 line, -6 lines 0 comments Download
M ui/views/controls/menu/menu_separator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_separator_win.cc View 2 chunks +1 line, -8 lines 0 comments Download
M ui/views/controls/native/native_view_host.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/controls/native/native_view_host_unittest.cc View 2 chunks +1 line, -14 lines 0 comments Download
M ui/views/controls/resize_area.cc View 1 2 2 chunks +2 lines, -12 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_button.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/single_split_view.cc View 2 chunks +1 line, -10 lines 0 comments Download
M ui/views/controls/table/table_header.cc View 4 chunks +2 lines, -14 lines 0 comments Download
M ui/views/controls/webview/unhandled_keyboard_event_handler_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 1 1 chunk +1 line, -13 lines 0 comments Download
M ui/views/drag_utils.cc View 4 chunks +2 lines, -22 lines 0 comments Download
M ui/views/event_utils_win.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 4 chunks +5 lines, -12 lines 0 comments Download
M ui/views/focus/focus_manager_test.h View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/focus/focus_manager_test.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M ui/views/focus/focus_manager_unittest.cc View 1 2 4 chunks +4 lines, -36 lines 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/mouse_watcher.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M ui/views/test/desktop_test_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/test_views_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/test/test_views_delegate.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M ui/views/test/widget_test.h View 1 3 chunks +1 line, -13 lines 0 comments Download
M ui/views/test/widget_test.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M ui/views/view.cc View 5 chunks +2 lines, -20 lines 0 comments Download
M ui/views/view_unittest.cc View 1 2 10 chunks +6 lines, -16 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ui/views/widget/widget.cc View 3 chunks +1 line, -6 lines 0 comments Download
M ui/views/widget/widget_hwnd_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 6 chunks +10 lines, -17 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 27 chunks +30 lines, -39 lines 0 comments Download
M ui/views/window/custom_frame_view.cc View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
sky
6 years, 9 months ago (2014-03-08 00:37:38 UTC) #1
msw
driveby nits. https://codereview.chromium.org/191723003/diff/20001/ui/views/controls/native/native_view_host.cc File ui/views/controls/native/native_view_host.cc (left): https://codereview.chromium.org/191723003/diff/20001/ui/views/controls/native/native_view_host.cc#oldcode23 ui/views/controls/native/native_view_host.cc:23: const bool NativeViewHost::kRenderNativeControlFocus = false; nit: this ...
6 years, 9 months ago (2014-03-08 01:04:49 UTC) #2
sky
https://codereview.chromium.org/191723003/diff/20001/ui/views/controls/native/native_view_host.cc File ui/views/controls/native/native_view_host.cc (left): https://codereview.chromium.org/191723003/diff/20001/ui/views/controls/native/native_view_host.cc#oldcode23 ui/views/controls/native/native_view_host.cc:23: const bool NativeViewHost::kRenderNativeControlFocus = false; On 2014/03/08 01:04:50, msw ...
6 years, 9 months ago (2014-03-08 01:30:28 UTC) #3
Ben Goodger (Google)
lgtm yay!
6 years, 9 months ago (2014-03-08 01:32:21 UTC) #4
msw
lgtm
6 years, 9 months ago (2014-03-08 01:38:21 UTC) #5
sky
The CQ bit was checked by sky@chromium.org
6 years, 9 months ago (2014-03-08 03:18:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/191723003/40001
6 years, 9 months ago (2014-03-08 11:20:40 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-08 14:27:35 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) telemetry_perf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=234385
6 years, 9 months ago (2014-03-08 14:27:36 UTC) #9
sky
The CQ bit was checked by sky@chromium.org
6 years, 9 months ago (2014-03-10 13:06:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/191723003/40001
6 years, 9 months ago (2014-03-10 13:12:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/191723003/40001
6 years, 9 months ago (2014-03-10 14:21:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/191723003/40001
6 years, 9 months ago (2014-03-10 15:38:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/191723003/40001
6 years, 9 months ago (2014-03-10 17:36:57 UTC) #14
commit-bot: I haz the power
6 years, 9 months ago (2014-03-10 18:12:22 UTC) #15
Message was sent while issue was closed. 
Change committed as 255976

Powered by Google App Engine
This is Rietveld 408576698