| Index: ui/views/widget/widget_unittest.cc
|
| diff --git a/ui/views/widget/widget_unittest.cc b/ui/views/widget/widget_unittest.cc
|
| index 1b10418259908312fed5b4f8776ce8b9e54bca0d..4d33b2b54cd94eb4949127376ab81d0769c0333d 100644
|
| --- a/ui/views/widget/widget_unittest.cc
|
| +++ b/ui/views/widget/widget_unittest.cc
|
| @@ -308,11 +308,11 @@ struct OwnershipTestState {
|
|
|
| // A platform NativeWidget subclass that updates a bag of state when it is
|
| // destroyed.
|
| -class OwnershipTestNativeWidget : public NativeWidgetPlatform {
|
| +class OwnershipTestNativeWidget : public NativeWidgetAura {
|
| public:
|
| OwnershipTestNativeWidget(internal::NativeWidgetDelegate* delegate,
|
| OwnershipTestState* state)
|
| - : NativeWidgetPlatform(delegate),
|
| + : NativeWidgetAura(delegate),
|
| state_(state) {
|
| }
|
| virtual ~OwnershipTestNativeWidget() {
|
| @@ -327,21 +327,21 @@ class OwnershipTestNativeWidget : public NativeWidgetPlatform {
|
|
|
| // A views NativeWidget subclass that updates a bag of state when it is
|
| // destroyed.
|
| -class OwnershipTestNativeWidgetPlatform : public NativeWidgetPlatformForTest {
|
| +class OwnershipTestNativeWidgetAura : public NativeWidgetCapture {
|
| public:
|
| - OwnershipTestNativeWidgetPlatform(internal::NativeWidgetDelegate* delegate,
|
| - OwnershipTestState* state)
|
| - : NativeWidgetPlatformForTest(delegate),
|
| + OwnershipTestNativeWidgetAura(internal::NativeWidgetDelegate* delegate,
|
| + OwnershipTestState* state)
|
| + : NativeWidgetCapture(delegate),
|
| state_(state) {
|
| }
|
| - virtual ~OwnershipTestNativeWidgetPlatform() {
|
| + virtual ~OwnershipTestNativeWidgetAura() {
|
| state_->native_widget_deleted = true;
|
| }
|
|
|
| private:
|
| OwnershipTestState* state_;
|
|
|
| - DISALLOW_COPY_AND_ASSIGN(OwnershipTestNativeWidgetPlatform);
|
| + DISALLOW_COPY_AND_ASSIGN(OwnershipTestNativeWidgetAura);
|
| };
|
|
|
| // A Widget subclass that updates a bag of state when it is destroyed.
|
| @@ -366,7 +366,7 @@ TEST_F(WidgetOwnershipTest, Ownership_WidgetOwnsPlatformNativeWidget) {
|
| scoped_ptr<Widget> widget(new OwnershipTestWidget(&state));
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget.get(), &state);
|
| + new OwnershipTestNativeWidgetAura(widget.get(), &state);
|
| params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
|
| widget->Init(params);
|
|
|
| @@ -387,7 +387,7 @@ TEST_F(WidgetOwnershipTest, Ownership_WidgetOwnsViewsNativeWidget) {
|
| scoped_ptr<Widget> widget(new OwnershipTestWidget(&state));
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget.get(), &state);
|
| + new OwnershipTestNativeWidgetAura(widget.get(), &state);
|
| params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
|
| widget->Init(params);
|
|
|
| @@ -412,7 +412,7 @@ TEST_F(WidgetOwnershipTest,
|
| scoped_ptr<Widget> widget(new OwnershipTestWidget(&state));
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget.get(), &state);
|
| + new OwnershipTestNativeWidgetAura(widget.get(), &state);
|
| params.parent = toplevel->GetNativeView();
|
| params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
|
| widget->Init(params);
|
| @@ -442,7 +442,7 @@ TEST_F(WidgetOwnershipTest, Ownership_PlatformNativeWidgetOwnsWidget) {
|
| Widget* widget = new OwnershipTestWidget(&state);
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget, &state);
|
| + new OwnershipTestNativeWidgetAura(widget, &state);
|
| widget->Init(params);
|
|
|
| // Now destroy the native widget.
|
| @@ -461,7 +461,7 @@ TEST_F(WidgetOwnershipTest, Ownership_ViewsNativeWidgetOwnsWidget) {
|
| Widget* widget = new OwnershipTestWidget(&state);
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget, &state);
|
| + new OwnershipTestNativeWidgetAura(widget, &state);
|
| params.parent = toplevel->GetNativeView();
|
| widget->Init(params);
|
|
|
| @@ -485,15 +485,11 @@ TEST_F(WidgetOwnershipTest,
|
| Widget* widget = new OwnershipTestWidget(&state);
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget, &state);
|
| + new OwnershipTestNativeWidgetAura(widget, &state);
|
| widget->Init(params);
|
|
|
| // Now simulate a destroy of the platform native widget from the OS:
|
| -#if defined(USE_AURA)
|
| delete widget->GetNativeView();
|
| -#elif defined(OS_WIN)
|
| - DestroyWindow(widget->GetNativeView());
|
| -#endif
|
|
|
| EXPECT_TRUE(state.widget_deleted);
|
| EXPECT_TRUE(state.native_widget_deleted);
|
| @@ -510,7 +506,7 @@ TEST_F(WidgetOwnershipTest,
|
| Widget* widget = new OwnershipTestWidget(&state);
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget, &state);
|
| + new OwnershipTestNativeWidgetAura(widget, &state);
|
| params.parent = toplevel->GetNativeView();
|
| widget->Init(params);
|
|
|
| @@ -536,7 +532,7 @@ TEST_F(WidgetOwnershipTest,
|
| Widget* widget = new OwnershipTestWidget(&state);
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget, &state);
|
| + new OwnershipTestNativeWidgetAura(widget, &state);
|
| params.parent = toplevel->GetNativeView();
|
| widget->Init(params);
|
|
|
| @@ -562,7 +558,7 @@ TEST_F(WidgetOwnershipTest,
|
| scoped_ptr<Widget> widget(new OwnershipTestWidget(&state));
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| params.native_widget =
|
| - new OwnershipTestNativeWidgetPlatform(widget.get(), &state);
|
| + new OwnershipTestNativeWidgetAura(widget.get(), &state);
|
| params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
|
| params.delegate = delegate_view;
|
| widget->Init(params);
|
| @@ -647,7 +643,7 @@ TEST_F(WidgetWithDestroyedNativeViewTest, Test) {
|
| widget.native_widget_private()->CloseNow();
|
| InvokeWidgetMethods(&widget);
|
| }
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| {
|
| Widget widget;
|
| Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_POPUP);
|
| @@ -831,7 +827,7 @@ TEST_F(WidgetObserverTest, WidgetBoundsChanged) {
|
| EXPECT_EQ(child2, widget_bounds_changed());
|
| }
|
|
|
| -#if !defined(USE_AURA) && defined(OS_WIN)
|
| +#if defined(false)
|
| // Aura needs shell to maximize/fullscreen window.
|
| // NativeWidgetGtk doesn't implement GetRestoredBounds.
|
| TEST_F(WidgetTest, GetRestoredBounds) {
|
| @@ -900,7 +896,6 @@ TEST_F(WidgetTest, ExitFullscreenRestoreState) {
|
| RunPendingMessages();
|
| }
|
|
|
| -#if defined(USE_AURA)
|
| // The key-event propagation from Widget happens differently on aura and
|
| // non-aura systems because of the difference in IME. So this test works only on
|
| // aura.
|
| @@ -1389,8 +1384,6 @@ TEST_F(WidgetTest, WheelEventsFromScrollEventTarget) {
|
| widget->CloseNow();
|
| }
|
|
|
| -#endif // defined(USE_AURA)
|
| -
|
| // Tests that if a scroll-begin gesture is not handled, then subsequent scroll
|
| // events are not dispatched to any view.
|
| TEST_F(WidgetTest, GestureScrollEventDispatching) {
|
| @@ -1580,7 +1573,7 @@ TEST_F(WidgetTest, SingleWindowClosing) {
|
| CreateParams(Widget::InitParams::TYPE_WINDOW);
|
| init_params.bounds = gfx::Rect(0, 0, 200, 200);
|
| init_params.delegate = delegate.get();
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| init_params.native_widget = new DesktopNativeWidgetAura(widget);
|
| #endif
|
| widget->Init(init_params);
|
| @@ -1597,7 +1590,7 @@ class WidgetWindowTitleTest : public WidgetTest {
|
| CreateParams(Widget::InitParams::TYPE_WINDOW);
|
| widget->Init(init_params);
|
|
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| if (desktop_native_widget)
|
| init_params.native_widget = new DesktopNativeWidgetAura(widget);
|
| #else
|
| @@ -1638,13 +1631,13 @@ TEST_F(WidgetWindowTitleTest, SetWindowTitleChanged_NativeWidget) {
|
| }
|
|
|
| // DesktopNativeWidget does not exist on non-Aura or on ChromeOS.
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| TEST_F(WidgetWindowTitleTest, SetWindowTitleChanged_DesktopNativeWidget) {
|
| // Override to use a DesktopNativeWidget.
|
| bool desktop_native_widget = true;
|
| RunTest(desktop_native_widget);
|
| }
|
| -#endif // USE_AURA && !OS_CHROMEOS
|
| +#endif // !OS_CHROMEOS
|
|
|
| // Used by SetTopLevelCorrectly to track calls to OnBeforeWidgetInit().
|
| class VerifyTopLevelDelegate : public TestViewsDelegate {
|
| @@ -1758,7 +1751,7 @@ bool RunGetNativeThemeFromDestructor(const Widget::InitParams& in_params,
|
| Widget::InitParams params(in_params);
|
| // Deletes itself when the Widget is destroyed.
|
| params.delegate = new GetNativeThemeFromDestructorView;
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| if (is_first_run) {
|
| params.native_widget = new DesktopNativeWidgetAura(widget);
|
| needs_second_run = true;
|
| @@ -1807,7 +1800,7 @@ TEST_F(WidgetTest, CloseDestroys) {
|
| Widget::InitParams params =
|
| CreateParams(views::Widget::InitParams::TYPE_MENU);
|
| params.opacity = Widget::InitParams::OPAQUE_WINDOW;
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| params.native_widget = new DesktopNativeWidgetAura(widget);
|
| #endif
|
| widget->Init(params);
|
| @@ -1965,7 +1958,7 @@ class WidgetChildDestructionTest : public WidgetTest {
|
| Widget* top_level = new Widget;
|
| Widget::InitParams params =
|
| CreateParams(views::Widget::InitParams::TYPE_WINDOW);
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| if (top_level_has_desktop_native_widget_aura)
|
| params.native_widget = new DesktopNativeWidgetAura(top_level);
|
| #endif
|
| @@ -1978,7 +1971,7 @@ class WidgetChildDestructionTest : public WidgetTest {
|
| Widget::InitParams child_params =
|
| CreateParams(views::Widget::InitParams::TYPE_POPUP);
|
| child_params.parent = top_level->GetNativeView();
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| if (child_has_desktop_native_widget_aura)
|
| child_params.native_widget = new DesktopNativeWidgetAura(child);
|
| #endif
|
| @@ -2000,7 +1993,7 @@ class WidgetChildDestructionTest : public WidgetTest {
|
| DISALLOW_COPY_AND_ASSIGN(WidgetChildDestructionTest);
|
| };
|
|
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| // See description of RunDestroyChildWidgetsTest(). Parent uses
|
| // DesktopNativeWidgetAura.
|
| TEST_F(WidgetChildDestructionTest,
|
| @@ -2021,7 +2014,7 @@ TEST_F(WidgetChildDestructionTest, DestroyChildWidgetsInOrder) {
|
| RunDestroyChildWidgetsTest(false, false);
|
| }
|
|
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| // Provides functionality to create a window modal dialog.
|
| class ModalDialogDelegate : public DialogDelegateView {
|
| public:
|
| @@ -2114,7 +2107,6 @@ TEST_F(WidgetTest, WindowMouseModalityTest) {
|
| top_level_widget.CloseNow();
|
| }
|
|
|
| -#if defined(USE_AURA)
|
| // Verifies nativeview visbility matches that of Widget visibility when
|
| // SetFullscreen is invoked.
|
| TEST_F(WidgetTest, FullscreenStatePropagated) {
|
| @@ -2145,7 +2137,6 @@ TEST_F(WidgetTest, FullscreenStatePropagated) {
|
| }
|
| #endif
|
| }
|
| -#endif
|
|
|
| #if defined(OS_WIN)
|
|
|
| @@ -2279,7 +2270,7 @@ TEST_F(WidgetTest, ShowAfterShowInactive) {
|
| widget->CloseNow();
|
| }
|
|
|
| -#if defined(USE_AURA) && !defined(OS_CHROMEOS)
|
| +#if !defined(OS_CHROMEOS)
|
| TEST_F(WidgetTest, InactiveWidgetDoesNotGrabActivation) {
|
| Widget* widget = CreateTopLevelPlatformWidget();
|
| widget->Show();
|
|
|