Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1916923005: Disallow direct use of AllowCrossThreadAccessWrapper (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Kuroneko_prep0
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disallow direct use of AllowCrossThreadAccessWrapper Use AllowCrossThreadAccess() instead. BUG=597856 Committed: https://crrev.com/331e4aa7f90abc5a73052d21627e891959851c73 Cr-Commit-Position: refs/heads/master@{#390355}

Patch Set 1 #

Patch Set 2 : auto-Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/CrossThreadCopier.h View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916923005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916923005/1
4 years, 7 months ago (2016-04-27 08:12:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916923005/20001
4 years, 7 months ago (2016-04-27 09:27:19 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 11:25:01 UTC) #6
hiroshige
PTAL.
4 years, 7 months ago (2016-04-28 06:44:50 UTC) #9
haraken
LGTM
4 years, 7 months ago (2016-04-28 07:38:06 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 1923183002 Patch 20001). Please resolve the dependency and ...
4 years, 7 months ago (2016-04-28 08:03:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916923005/20001
4 years, 7 months ago (2016-04-28 09:58:20 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 12:35:34 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:42 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/331e4aa7f90abc5a73052d21627e891959851c73
Cr-Commit-Position: refs/heads/master@{#390355}

Powered by Google App Engine
This is Rietveld 408576698