third_party/WebKit/Source/platform/heap/HeapTest.cpp - Issue 1916923005: Disallow direct use of AllowCrossThreadAccessWrapper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 1916923005: Disallow direct use of AllowCrossThreadAccessWrapper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Kuroneko_prep0

Patch Set: auto-Rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp

diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

index f9d13e1759ec8f0d305b7fe69933b8161e28e175..c6d7f60d54fc510c34622684c5b0ef612be562a2 100644

--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp

+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

@@ -6398,7 +6398,7 @@ TEST(HeapTest, CrossThreadWeakPersistent)

MutexLocker mainThreadMutexLocker(mainThreadMutex());

OwnPtr<WebThread> workerThread = adoptPtr(Platform::current()->createThread("Test Worker Thread"));

DestructorLockingObject* object = nullptr;

- workerThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(workerThreadMainForCrossThreadWeakPersistentTest, AllowCrossThreadAccessWrapper<DestructorLockingObject**>(&object)));

+ workerThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(workerThreadMainForCrossThreadWeakPersistentTest, AllowCrossThreadAccess(&object)));

parkMainThread();

// Step 3: Set up a CrossThreadWeakPersistent.

« no previous file with comments | « third_party/WebKit/Source/platform/CrossThreadCopier.h ('k') | no next file » | no next file with comments »