Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1923183002: Add support for IsGarbageCollectedType<void> (Closed)

Created:
4 years, 8 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
haraken, sof, Yuta Kitamura
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for IsGarbageCollectedType<void> Currently IsGarbageCollectedType<void> and PointerParamStorageTraits<void*> can't be compiled. This CL makes them successfully compiled, and removes ParamStorageTraits<void*> specialization. BUG=597856 Committed: https://crrev.com/bc00ec091a4ff8073390fc97a692613e2d40ee90 Cr-Commit-Position: refs/heads/master@{#390331}

Patch Set 1 #

Patch Set 2 : auto-Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/heap/GarbageCollected.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/Handle.h View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/Functional.h View 1 chunk +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923183002/1
4 years, 8 months ago (2016-04-27 07:36:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923183002/20001
4 years, 8 months ago (2016-04-27 09:27:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 12:57:34 UTC) #6
hiroshige
PTAL.
4 years, 7 months ago (2016-04-28 06:03:10 UTC) #9
sof
lgtm
4 years, 7 months ago (2016-04-28 06:08:57 UTC) #11
hiroshige
haraken@, could you take a look as a wtf OWNER?
4 years, 7 months ago (2016-04-28 06:36:32 UTC) #14
Yuta Kitamura
LGTM, I think this is better.
4 years, 7 months ago (2016-04-28 06:39:28 UTC) #15
haraken
LGTM
4 years, 7 months ago (2016-04-28 07:38:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923183002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923183002/20001
4 years, 7 months ago (2016-04-28 08:43:41 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-28 08:48:29 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:17:06 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bc00ec091a4ff8073390fc97a692613e2d40ee90
Cr-Commit-Position: refs/heads/master@{#390331}

Powered by Google App Engine
This is Rietveld 408576698