Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1916323002: [MD settings] side nav routing to page sections (Closed)

Created:
4 years, 8 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, jlklein+watch-closure_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] side nav routing to page sections This CL makes the side nav show the correct settings section when selecting a page in the menu. Several routes have been added for top-level pages (non-subpages). A SettingsRoute closure type has been defined. BUG=604942, 593989, 584478, 606632 Committed: https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd Cr-Commit-Position: refs/heads/master@{#390802}

Patch Set 1 : fix for people page test #

Total comments: 16

Patch Set 2 : review changes #

Patch Set 3 : merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -47 lines) Patch
M chrome/browser/resources/settings/advanced_page/advanced_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/advanced_page/advanced_page.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/advanced_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.js View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/compiled_resources2.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 2 chunks +29 lines, -23 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 1 4 chunks +20 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_animated_pages.js View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_router.js View 1 2 12 chunks +110 lines, -6 lines 0 comments Download
M chrome/test/data/webui/settings/people_page_test.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
dschuyler
4 years, 8 months ago (2016-04-26 19:09:31 UTC) #5
dschuyler
On 2016/04/26 19:09:31, dschuyler wrote: I filed bug 606876 to follow up on URLs for ...
4 years, 8 months ago (2016-04-26 19:19:24 UTC) #6
michaelpg
the problem seems to be that even document.body still has a computed display property of ...
4 years, 7 months ago (2016-04-28 00:33:43 UTC) #7
michaelpg
This looks good. https://codereview.chromium.org/1916323002/diff/40001/chrome/browser/resources/settings/settings_page/main_page_behavior.js File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/1916323002/diff/40001/chrome/browser/resources/settings/settings_page/main_page_behavior.js#newcode339 chrome/browser/resources/settings/settings_page/main_page_behavior.js:339: // TODO(dschuyler): Determine whether this setTimeout ...
4 years, 7 months ago (2016-04-29 20:19:04 UTC) #8
dschuyler
https://codereview.chromium.org/1916323002/diff/40001/chrome/browser/resources/settings/settings_page/main_page_behavior.js File chrome/browser/resources/settings/settings_page/main_page_behavior.js (right): https://codereview.chromium.org/1916323002/diff/40001/chrome/browser/resources/settings/settings_page/main_page_behavior.js#newcode339 chrome/browser/resources/settings/settings_page/main_page_behavior.js:339: // TODO(dschuyler): Determine whether this setTimeout can be removed. ...
4 years, 7 months ago (2016-04-29 21:27:47 UTC) #9
michaelpg
lgtm
4 years, 7 months ago (2016-04-29 23:25:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1916323002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1916323002/80001
4 years, 7 months ago (2016-04-29 23:27:09 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:80001)
4 years, 7 months ago (2016-04-29 23:32:33 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:30:07 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e46c22835a225bc3c6361a45fa3558400eb7b5dd
Cr-Commit-Position: refs/heads/master@{#390802}

Powered by Google App Engine
This is Rietveld 408576698