Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5239)

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.js

Issue 1916323002: [MD settings] side nav routing to page sections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge with master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/basic_page/basic_page.js
diff --git a/chrome/browser/resources/settings/basic_page/basic_page.js b/chrome/browser/resources/settings/basic_page/basic_page.js
index 80787fc349b749c512321e0cdef9391b7f6eb4fc..b16ed1dfe6deed7a6dcac22dadc15ad3a6ed1218 100644
--- a/chrome/browser/resources/settings/basic_page/basic_page.js
+++ b/chrome/browser/resources/settings/basic_page/basic_page.js
@@ -16,6 +16,8 @@
Polymer({
is: 'settings-basic-page',
+ behaviors: [I18nBehavior, SettingsPageVisibility, RoutableBehavior],
+
properties: {
/**
* Preferences state.
@@ -27,6 +29,7 @@ Polymer({
/**
* The current active route.
+ * @type {SettingsRoute}
*/
currentRoute: {
type: Object,
@@ -59,8 +62,6 @@ Polymer({
this.scroller = this.parentElement;
},
- behaviors: [I18nBehavior, SettingsPageVisibility, RoutableBehavior],
-
onResetDone_: function() {
this.showResetProfileBanner_ = false;
},

Powered by Google App Engine
This is Rietveld 408576698