chrome/browser/resources/settings/settings_page/settings_animated_pages.js - Issue 1916323002: [MD settings] side nav routing to page sections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Issue 1916323002: [MD settings] side nav routing to page sections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge with master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings_page/main_page_behavior.js ('k') | chrome/browser/resources/settings/settings_page/settings_router.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

index fc205a6d2b9f4b6e3ec3cee574cb6c0e5ea1408e..08a561a26c6827d6d19cfd1f6e281f80f17dc643 100644

--- a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

+++ b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

@@ -88,11 +88,8 @@ Polymer({

return;

}

- // route.section is only non-empty when the user is within a subpage.

- // When the user is not in a subpage, but on the Basic page, route.section

- // is an empty string.

- var newRouteIsSubpage = newRoute && newRoute.section == this.section;

- var oldRouteIsSubpage = oldRoute && oldRoute.section == this.section;

+ var newRouteIsSubpage = newRoute && newRoute.subpage.length;

+ var oldRouteIsSubpage = oldRoute && oldRoute.subpage.length;

if (newRouteIsSubpage)

this.ensureSubpageInstance_();