Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2973)

Unified Diff: chrome/browser/resources/settings/settings_menu/settings_menu.html

Issue 1916323002: [MD settings] side nav routing to page sections (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge with master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_menu/settings_menu.html
diff --git a/chrome/browser/resources/settings/settings_menu/settings_menu.html b/chrome/browser/resources/settings/settings_menu/settings_menu.html
index e0957cf53f665d8538ee5da1dfebddb23c7513c6..679a02c9efefffae348ddce152aad74348bd4d2f 100644
--- a/chrome/browser/resources/settings/settings_menu/settings_menu.html
+++ b/chrome/browser/resources/settings/settings_menu/settings_menu.html
@@ -19,7 +19,11 @@
<style include="settings-shared">
iron-icon {
--iron-icon-fill-color: var(--settings-nav-grey);
- -webkit-margin-end: 16px;
+ -webkit-margin-end: 24px;
+ }
+
+ .iron-selected:not(.menu-trigger) > iron-icon {
+ fill: var(--google-blue-500);
}
.menu-trigger span {
@@ -63,96 +67,98 @@
}
</style>
<paper-menu name="root-menu">
- <paper-submenu opened="{{basicOpened_}}" data-page="basic"
- on-tap="openPage_">
- <div class="menu-trigger">
+ <paper-submenu opened="{{basicOpened_}}">
+ <div class="menu-trigger" data-page="basic" data-section=""
+ on-tap="openPage_">
<span i18n-content="basicPageTitle"></span>
<iron-icon icon="{{arrowState_(basicOpened_)}}" item-icon></iron-icon>
</div>
<paper-menu class="menu-content">
<if expr="chromeos">
- <div>
+ <div data-page="basic" data-section="internet" on-tap="openPage_">
<iron-icon icon="device:network-wifi" item-icon></iron-icon>
<span i18n-content="internetPageTitle"></span>
</div>
</if>
- <div>
+ <div data-page="basic" data-section="people" on-tap="openPage_">
<iron-icon icon="social:people" item-icon></iron-icon>
<span i18n-content="peoplePageTitle"></span>
</div>
- <div>
+ <div data-page="basic" data-section="appearance" on-tap="openPage_">
<iron-icon icon="image:palette" item-icon></iron-icon>
<span i18n-content="appearancePageTitle"></span>
</div>
<if expr="chromeos">
- <div>
+ <div data-page="basic" data-section="device" on-tap="openPage_">
<iron-icon icon="hardware:laptop-chromebook" item-icon></iron-icon>
<span i18n-content="devicePageTitle"></span>
</div>
</if>
- <div>
+ <div data-page="basic" data-section="search" on-tap="openPage_">
<iron-icon icon="search" item-icon></iron-icon>
<span i18n-content="searchPageTitle"></span>
</div>
<if expr="not chromeos">
- <div>
+ <div data-page="basic" data-section="defaultBrowser"
+ on-tap="openPage_">
<iron-icon icon="av:web" item-icon></iron-icon>
<span i18n-content="defaultBrowser"></span>
</div>
</if>
- <div>
+ <div data-page="basic" data-section="onStartup" on-tap="openPage_">
<iron-icon icon="icons:power-settings-new" item-icon></iron-icon>
<span i18n-content="onStartup"></span>
</div>
</paper-menu>
</paper-submenu>
- <paper-submenu opened="{{advancedOpened_}}" data-page="advanced"
- on-tap="openPage_">
- <div class="menu-trigger">
+ <paper-submenu opened="{{advancedOpened_}}">
+ <div class="menu-trigger" data-page="advanced" data-section=""
+ on-tap="openPage_">
<span i18n-content="advancedPageTitle"></span>
<iron-icon icon="{{arrowState_(advancedOpened_)}}" item-icon>
</iron-icon>
</div>
<paper-menu class="menu-content">
<if expr="chromeos">
- <div>
+ <div data-page="advanced" data-section="dateTime" on-tap="openPage_">
<iron-icon icon="device:access-time" item-icon></iron-icon>
<span i18n-content="dateTimePageTitle"></span>
</div>
</if>
- <div>
+ <div data-page="advanced" data-section="privacy" on-tap="openPage_">
<iron-icon icon="hardware:security" item-icon></iron-icon>
<span i18n-content="privacyPageTitle"></span>
</div>
<if expr="chromeos">
- <div>
+ <div data-page="advanced" data-section="bluetooth" on-tap="openPage_">
<iron-icon icon="device:bluetooth" item-icon></iron-icon>
<span i18n-content="bluetoothPageTitle"></span>
</div>
</if>
- <div>
+ <div data-page="advanced" data-section="passwordsAndForms"
+ on-tap="openPage_">
<iron-icon icon="icons:assignment" item-icon></iron-icon>
<span i18n-content="passwordsAndAutofillPageTitle"></span>
</div>
- <div>
+ <div data-page="advanced" data-section="languages" on-tap="openPage_">
<iron-icon icon="icons:language" item-icon></iron-icon>
<span i18n-content="languagesPageTitle"></span>
</div>
- <div>
+ <div data-page="advanced" data-section="downloads" on-tap="openPage_">
<iron-icon icon="icons:file-download" item-icon></iron-icon>
<span i18n-content="downloadsPageTitle"></span>
</div>
- <div>
+ <div data-page="advanced" data-section="a11y" on-tap="openPage_">
<iron-icon icon="icons:accessibility" item-icon></iron-icon>
<span i18n-content="a11yPageTitle"></span>
</div>
<if expr="not chromeos">
- <div>
+ <div data-page="advanced" data-section="system" on-tap="openPage_">
<iron-icon icon="icons:build" item-icon></iron-icon>
<span i18n-content="systemPageTitle"></span>
</div>
</if>
- <div>
+ <div data-page="advanced" data-section="reset" on-tap="openPage_">
<iron-icon icon="icons:restore" item-icon></iron-icon>
<span i18n-content="resetPageTitle"></span>
</div>

Powered by Google App Engine
This is Rietveld 408576698