Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1915363002: Rename gfx::Display/Screen to display::Display/Screen in views/wm (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, msw+watch_chromium.org, sadrul, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, dcheng, nona+watch_chromium.org, groby+bubble_chromium.org, hcarmona+bubble_chromium.org, kalyank, James Su, rouslan+bubble_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in views/wm Cleanup forward delcs/includes. BUG=597761 Committed: https://crrev.com/34e636fd63be7e58c93bff3d22684adbf68adb0c Cr-Commit-Position: refs/heads/master@{#389941}

Patch Set 1 : #

Patch Set 2 : more cleanups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -302 lines) Patch
M ui/views/bubble/bubble_frame_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_button.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_button.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/corewm/tooltip_win.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M ui/views/drag_utils.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/examples/examples_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mouse_watcher_view_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/mus/display_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/mus/display_converter.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/mus/screen_mus.h View 4 chunks +16 lines, -14 lines 0 comments Download
M ui/views/mus/screen_mus.cc View 9 chunks +38 lines, -33 lines 0 comments Download
M ui/views/test/desktop_screen_x11_test_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/view.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_cursor_loader_updater.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_cursor_loader_updater_auralinux.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_cursor_loader_updater_auralinux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_factory_ozone.h View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_cursor_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen.h View 1 chunk +5 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.h View 1 4 chunks +17 lines, -18 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 15 chunks +33 lines, -34 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 17 chunks +84 lines, -67 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/tooltip_manager.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/wm/core/cursor_manager.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/wm/core/cursor_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/cursor_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/default_screen_position_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/default_screen_position_client.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ui/wm/core/native_cursor_manager.h View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/wm/core/window_animations.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/wm.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (18 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915363002/20001
4 years, 7 months ago (2016-04-26 00:58:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915363002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915363002/40001
4 years, 7 months ago (2016-04-26 01:03:37 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915363002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915363002/100001
4 years, 7 months ago (2016-04-26 21:06:11 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 22:08:44 UTC) #13
oshima
4 years, 7 months ago (2016-04-26 22:35:43 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915363002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915363002/120001
4 years, 7 months ago (2016-04-26 22:36:22 UTC) #20
sky
Rubber stamp LGTM
4 years, 7 months ago (2016-04-26 23:19:31 UTC) #21
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-26 23:24:28 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1915363002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1915363002/120001
4 years, 7 months ago (2016-04-26 23:28:17 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 7 months ago (2016-04-26 23:34:27 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-04-26 23:35:33 UTC) #29
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34e636fd63be7e58c93bff3d22684adbf68adb0c
Cr-Commit-Position: refs/heads/master@{#389941}

Powered by Google App Engine
This is Rietveld 408576698