Issue 1915063003: Change ContentSettingImageView activation to key release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1915063003: Change ContentSettingImageView activation to key release (Closed)

Created:
4 years, 8 months ago by Evan Stade

Modified:
4 years, 8 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change ContentSettingImageView activation to key release And standardize all BubbleIconViews as well: instead of activating on key down, activate on key up. This matches buttons (such as the toolbar buttons) and the ev cert icon. Showing the bubble on key down means that the key up activates the newly-focused "done" button. BUG=602183 Review URL: https://codereview.chromium.org/1886943002 Cr-Commit-Position: refs/heads/master@{#389406} (cherry picked from commit ad2c35565eebbe4318c7a2ed950200b63599edf0)

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -101 lines)			Patch
M	chrome/browser/ui/views/location_bar/bubble_icon_view.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/bubble_icon_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/content_setting_image_view.h	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/content_setting_image_view.cc	View	3 chunks	+46 lines, -52 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/icon_label_bubble_view.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_icon_view.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_icon_view.cc	View	4 chunks	+24 lines, -39 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

4 years, 8 months ago (2016-04-25 20:54:00 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) to pending queue manually as
72c180bd653fa293113b7053f6c0700db6f704b4.

Expand Messages | Collapse Messages