chrome/browser/ui/views/location_bar/bubble_icon_view.h - Issue 1915063003: Change ContentSettingImageView activation to key release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.h

Issue 1915063003: Change ContentSettingImageView activation to key release (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.h

diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.h b/chrome/browser/ui/views/location_bar/bubble_icon_view.h

index ba5a44990d7f8dff0ceeec415c539b42a67a524a..12a95a656b8a59743ca1098886433fab06010375 100644

--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.h

+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.h

@@ -62,7 +62,7 @@ class BubbleIconView : public views::InkDropHostView,

void Layout() override;

bool OnMousePressed(const ui::MouseEvent& event) override;

void OnMouseReleased(const ui::MouseEvent& event) override;

- bool OnKeyPressed(const ui::KeyEvent& event) override;

+ bool OnKeyReleased(const ui::KeyEvent& event) override;

void ViewHierarchyChanged(

const ViewHierarchyChangedDetails& details) override;

void OnNativeThemeChanged(const ui::NativeTheme* theme) override;

« no previous file with comments | « no previous file | chrome/browser/ui/views/location_bar/bubble_icon_view.cc » ('j') | no next file with comments »