chrome/browser/ui/views/location_bar/bubble_icon_view.cc - Issue 1915063003: Change ContentSettingImageView activation to key release

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

Issue 1915063003: Change ContentSettingImageView activation to key release (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/bubble_icon_view.h ('k') | chrome/browser/ui/views/location_bar/content_setting_image_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/bubble_icon_view.cc

diff --git a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

index 8278ca941c1bf533357e9226fdf340ab2ac1d0bd..6b62f1134d08f37d2d30934cb25b28406d333254 100644

--- a/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

+++ b/chrome/browser/ui/views/location_bar/bubble_icon_view.cc

@@ -98,7 +98,7 @@ void BubbleIconView::OnMouseReleased(const ui::MouseEvent& event) {

ExecuteCommand(EXECUTE_SOURCE_MOUSE);

}

-bool BubbleIconView::OnKeyPressed(const ui::KeyEvent& event) {

+bool BubbleIconView::OnKeyReleased(const ui::KeyEvent& event) {

if (event.key_code() != ui::VKEY_SPACE && event.key_code() != ui::VKEY_RETURN)

return false;