Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2265)

Unified Diff: chrome/browser/ui/views/location_bar/content_setting_image_view.h

Issue 1915063003: Change ContentSettingImageView activation to key release (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/content_setting_image_view.h
diff --git a/chrome/browser/ui/views/location_bar/content_setting_image_view.h b/chrome/browser/ui/views/location_bar/content_setting_image_view.h
index af2b6c6c20da4b1c63d54652cceaad94a720d7ac..e6cc0d949eb7b53ece4770337b8ba3549c416418 100644
--- a/chrome/browser/ui/views/location_bar/content_setting_image_view.h
+++ b/chrome/browser/ui/views/location_bar/content_setting_image_view.h
@@ -66,7 +66,6 @@ class ContentSettingImageView : public IconLabelBubbleView,
void OnBoundsChanged(const gfx::Rect& previous_bounds) override;
bool OnMousePressed(const ui::MouseEvent& event) override;
void OnMouseReleased(const ui::MouseEvent& event) override;
- bool OnKeyPressed(const ui::KeyEvent& event) override;
void OnGestureEvent(ui::GestureEvent* event) override;
void OnNativeThemeChanged(const ui::NativeTheme* native_theme) override;
SkColor GetTextColor() const override;
@@ -74,6 +73,7 @@ class ContentSettingImageView : public IconLabelBubbleView,
bool ShouldShowBackground() const override;
double WidthMultiplier() const override;
bool IsShrinking() const override;
+ bool OnActivate() override;
// gfx::AnimationDelegate:
void AnimationEnded(const gfx::Animation* animation) override;
@@ -84,10 +84,6 @@ class ContentSettingImageView : public IconLabelBubbleView,
void OnWidgetDestroying(views::Widget* widget) override;
void OnWidgetVisibilityChanged(views::Widget* widget, bool visible) override;
- // Called when the user clicks the view; this freezes the animation or snaps
- // it to its end state as necessary and then opens a content setting bubble.
- void OnClick();
-
// Updates the image and tooltip to match the current model state.
void UpdateImage();

Powered by Google App Engine
This is Rietveld 408576698