Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: sdk/lib/_internal/js_runtime/lib/js_rti.dart

Issue 1913033002: dart2js: Pass type information to constructor rather than add later. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/js_runtime/lib/js_rti.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/js_rti.dart b/sdk/lib/_internal/js_runtime/lib/js_rti.dart
index 65ae2576c9ee0b882bfd868eeb21c4371b3ebbf0..f69f064ad41e0bf81fde6a8c89e2f25a82d1155c 100644
--- a/sdk/lib/_internal/js_runtime/lib/js_rti.dart
+++ b/sdk/lib/_internal/js_runtime/lib/js_rti.dart
@@ -96,7 +96,7 @@ getMangledTypeName(TypeImpl type) => type._typeName;
@NoInline()
Object setRuntimeTypeInfo(Object target, var rti) {
assert(rti == null || isJsArray(rti));
- JS('var', r'#.$builtinTypeInfo = #', target, rti);
+ JS('var', r'#.$ti = #', target, rti);
return target;
}
@@ -106,7 +106,7 @@ Object setRuntimeTypeInfo(Object target, var rti) {
*/
getRuntimeTypeInfo(Object target) {
if (target == null) return null;
- return JS('var', r'#.$builtinTypeInfo', target);
+ return JS('var', r'#.$ti', target);
}
/**
@@ -135,7 +135,7 @@ getTypeArgumentByIndex(Object target, int index) {
}
void copyTypeArguments(Object source, Object target) {
- JS('var', r'#.$builtinTypeInfo = #.$builtinTypeInfo', target, source);
+ JS('var', r'#.$ti = #.$ti', target, source);
}
/**
@@ -216,7 +216,7 @@ String joinArguments(var types, int startIndex,
String getRuntimeTypeString(var object) {
String className = getClassName(object);
if (object == null) return className;
- var rti = JS('var', r'#.$builtinTypeInfo', object);
+ var rti = JS('var', r'#.$ti', object);
return "$className${joinArguments(rti, 0)}";
}
« pkg/compiler/lib/src/ssa/builder.dart ('K') | « pkg/compiler/lib/src/ssa/codegen.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698