pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart - Issue 1913033002: dart2js: Pass type information to constructor rather than add later.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

Issue 1913033002: dart2js: Pass type information to constructor rather than add later. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('K') | « pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart ('k') | pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart » ('j') | pkg/compiler/lib/src/ssa/builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

diff --git a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

index 16ada26bf3693b0fc94edc5630d3698a39a9d316..3974b9fd0c7d076030e9544af440d3b6ab3f5869 100644

--- a/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

+++ b/pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart

@@ -312,13 +312,13 @@ class RuntimeTypeGenerator {

backend.rti.getSubstitution(cls, element.typeDeclaration);

if (substitution != null) {

computeTypeVariable = js(

- r'#.apply(null, this.$builtinTypeInfo)',

+ r'#.apply(null, this.$ti)',

backend.rtiEncoder

.getSubstitutionCodeForVariable(substitution, index));

} else {

// TODO(ahe): These can be generated dynamically.

computeTypeVariable = js(

- r'this.$builtinTypeInfo && this.$builtinTypeInfo[#]',

+ r'this.$ti && this.$ti[#]',

js.number(index));

}

jsAst.Expression convertRtiToRuntimeType = backend.emitter