pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart - Issue 1913033002: dart2js: Pass type information to constructor rather than add later.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

Issue 1913033002: dart2js: Pass type information to constructor rather than add later. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_emitter/class_stub_generator.dart ('K') | « pkg/compiler/lib/src/js_emitter/class_stub_generator.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart » ('j') | pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

index 0538a2d3fb896da80026a38fedb8e0a678908dca..f473235edac77b7c93fa9b1d3e5e98a2237fd92d 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart

@@ -35,6 +35,9 @@ class ClassEmitter extends CodeEmitterHelper {

builder.superName = superName;

emitConstructorsForCSP(cls);

emitFields(cls, builder);

+ if (cls.hasRti) {

+ builder.addField(namer.rtiFieldName);

+ }

emitCheckedClassSetters(cls, builder);

emitClassGettersSettersForCSP(cls, builder);

emitInstanceMembers(cls, builder);

@@ -69,8 +72,8 @@ class ClassEmitter extends CodeEmitterHelper {

ClassElement classElement = cls.element;

- jsAst.Expression constructorAst =

- _stubGenerator.generateClassConstructor(classElement, fieldNames);

+ jsAst.Expression constructorAst = _stubGenerator.generateClassConstructor(

+ classElement, fieldNames, cls.hasRti);

jsAst.Name constructorName = namer.className(classElement);

OutputUnit outputUnit =