Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1911873002: Store BundleData paths as SourceDirs rather than strings. (Closed)

Created:
4 years, 8 months ago by Robert Sesek
Modified:
4 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-phony-bundle-target
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store BundleData paths as SourceDirs rather than strings. R=brettw@chromium.org BUG=297668 Committed: https://crrev.com/54f052e1445e26b4fd8bd61748f4ee870872c2fa Cr-Commit-Position: refs/heads/master@{#389110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -37 lines) Patch
M tools/gn/bundle_data.h View 3 chunks +13 lines, -12 lines 0 comments Download
M tools/gn/bundle_data.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/gn/bundle_file_rule.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/gn/create_bundle_target_generator.h View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/gn/create_bundle_target_generator.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M tools/gn/ninja_create_bundle_target_writer_unittest.cc View 2 chunks +10 lines, -8 lines 0 comments Download

Depends on Patchset:

Issue 1892243002 Patch 40001

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 8 months ago (2016-04-21 21:30:29 UTC) #1
brettw
LGTM, thanks!
4 years, 8 months ago (2016-04-21 23:05:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1911873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1911873002/1
4 years, 8 months ago (2016-04-22 14:45:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 15:21:53 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:47:37 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/54f052e1445e26b4fd8bd61748f4ee870872c2fa
Cr-Commit-Position: refs/heads/master@{#389110}

Powered by Google App Engine
This is Rietveld 408576698