Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: tools/gn/create_bundle_target_generator.h

Issue 1911873002: Store BundleData paths as SourceDirs rather than strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-phony-bundle-target
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/bundle_file_rule.cc ('k') | tools/gn/create_bundle_target_generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/create_bundle_target_generator.h
diff --git a/tools/gn/create_bundle_target_generator.h b/tools/gn/create_bundle_target_generator.h
index db82b8a4c0bef2ca6c4f0a1546ca76216cdf083b..50040b8744d88ebf92331b9994502d7eb40377b9 100644
--- a/tools/gn/create_bundle_target_generator.h
+++ b/tools/gn/create_bundle_target_generator.h
@@ -8,6 +8,8 @@
#include "base/macros.h"
#include "tools/gn/target_generator.h"
+class SourceDir;
+
// Populates a Target with the values from a create_bundle rule.
class CreateBundleTargetGenerator : public TargetGenerator {
public:
@@ -21,9 +23,9 @@ class CreateBundleTargetGenerator : public TargetGenerator {
void DoRun() override;
private:
- bool GetBundleDir(const std::string& bundle_root_dir,
+ bool GetBundleDir(const SourceDir& bundle_root_dir,
const base::StringPiece& name,
- std::string* bundle_dir);
+ SourceDir* bundle_dir);
DISALLOW_COPY_AND_ASSIGN(CreateBundleTargetGenerator);
};
« no previous file with comments | « tools/gn/bundle_file_rule.cc ('k') | tools/gn/create_bundle_target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698