Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: tools/gn/create_bundle_target_generator.h

Issue 1911873002: Store BundleData paths as SourceDirs rather than strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-phony-bundle-target
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/gn/bundle_file_rule.cc ('k') | tools/gn/create_bundle_target_generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_CREATE_BUNDLE_TARGET_GENERATOR_H_ 5 #ifndef TOOLS_GN_CREATE_BUNDLE_TARGET_GENERATOR_H_
6 #define TOOLS_GN_CREATE_BUNDLE_TARGET_GENERATOR_H_ 6 #define TOOLS_GN_CREATE_BUNDLE_TARGET_GENERATOR_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "tools/gn/target_generator.h" 9 #include "tools/gn/target_generator.h"
10 10
11 class SourceDir;
12
11 // Populates a Target with the values from a create_bundle rule. 13 // Populates a Target with the values from a create_bundle rule.
12 class CreateBundleTargetGenerator : public TargetGenerator { 14 class CreateBundleTargetGenerator : public TargetGenerator {
13 public: 15 public:
14 CreateBundleTargetGenerator(Target* target, 16 CreateBundleTargetGenerator(Target* target,
15 Scope* scope, 17 Scope* scope,
16 const FunctionCallNode* function_call, 18 const FunctionCallNode* function_call,
17 Err* err); 19 Err* err);
18 ~CreateBundleTargetGenerator() override; 20 ~CreateBundleTargetGenerator() override;
19 21
20 protected: 22 protected:
21 void DoRun() override; 23 void DoRun() override;
22 24
23 private: 25 private:
24 bool GetBundleDir(const std::string& bundle_root_dir, 26 bool GetBundleDir(const SourceDir& bundle_root_dir,
25 const base::StringPiece& name, 27 const base::StringPiece& name,
26 std::string* bundle_dir); 28 SourceDir* bundle_dir);
27 29
28 DISALLOW_COPY_AND_ASSIGN(CreateBundleTargetGenerator); 30 DISALLOW_COPY_AND_ASSIGN(CreateBundleTargetGenerator);
29 }; 31 };
30 32
31 #endif // TOOLS_GN_CREATE_BUNDLE_TARGET_GENERATOR_H_ 33 #endif // TOOLS_GN_CREATE_BUNDLE_TARGET_GENERATOR_H_
OLDNEW
« no previous file with comments | « tools/gn/bundle_file_rule.cc ('k') | tools/gn/create_bundle_target_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698