tools/gn/bundle_file_rule.cc - Issue 1911873002: Store BundleData paths as SourceDirs rather than strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/bundle_file_rule.cc

Issue 1911873002: Store BundleData paths as SourceDirs rather than strings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-phony-bundle-target

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/bundle_file_rule.cc

diff --git a/tools/gn/bundle_file_rule.cc b/tools/gn/bundle_file_rule.cc

index 7684196c35646e5cf8887a28041e85b5ec1f59ae..9f78667779dd87de3821d7d12240e5a23d6c4fdd 100644

--- a/tools/gn/bundle_file_rule.cc

+++ b/tools/gn/bundle_file_rule.cc

@@ -29,16 +29,16 @@ SourceFile BundleFileRule::ApplyPatternToSource(

output_path.append(subrange.literal);

break;

case SUBSTITUTION_BUNDLE_ROOT_DIR:

- output_path.append(bundle_data.root_dir());

+ output_path.append(bundle_data.root_dir().value());

break;

case SUBSTITUTION_BUNDLE_RESOURCES_DIR:

- output_path.append(bundle_data.resources_dir());

+ output_path.append(bundle_data.resources_dir().value());

break;

case SUBSTITUTION_BUNDLE_EXECUTABLE_DIR:

- output_path.append(bundle_data.executable_dir());

+ output_path.append(bundle_data.executable_dir().value());

break;

case SUBSTITUTION_BUNDLE_PLUGINS_DIR:

- output_path.append(bundle_data.plugins_dir());

+ output_path.append(bundle_data.plugins_dir().value());

break;

default:

output_path.append(SubstitutionWriter::GetSourceSubstitution(

« no previous file with comments | « tools/gn/bundle_data.cc ('k') | tools/gn/create_bundle_target_generator.h » ('j') | no next file with comments »