Simplify the user agent code some more since after r255534 it's not affected by the site's URL.

Simplify the user agent code some more since after r255534 it's not affected by the site's URL.

Code in content always gets it now from ContentClient::GetUserAgent. In Chrome, there's a GetUserAgent function which returns it.

BUG=338338
R=isherman@chromium.org, pauljensen@chromium.org, scottmg@chromium.org, tfarina@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255858

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255877

[jam, 2014-03-07 17:43:52]

pauljensen: net
isherman: components/autofill
tfarina: the rest

[pauljensen, 2014-03-07 18:06:31]

net/ lgtm

[jam, 2014-03-07 20:57:21]

+scottmg as a main reviewer

[scottmg, 2014-03-07 21:19:48]

lgtm

https://codereview.chromium.org/191093002/diff/130001/content/test/webkit_sup...
File content/test/webkit_support.cc (left):

https://codereview.chromium.org/191093002/diff/130001/content/test/webkit_sup...
content/test/webkit_support.cc:114: "DumpRenderTree/0.0.0.0"));
Is this going to break blink tests?

[jam, 2014-03-07 21:34:53]

https://codereview.chromium.org/191093002/diff/130001/content/test/webkit_sup...
File content/test/webkit_support.cc (left):

https://codereview.chromium.org/191093002/diff/130001/content/test/webkit_sup...
content/test/webkit_support.cc:114: "DumpRenderTree/0.0.0.0"));
On 2014/03/07 21:19:48, scottmg wrote:
> Is this going to break blink tests?

I had searched for this string but didn't find it used anywhere else so I
thought it should be safe. I'll send out a try job to verify

[tfarina, 2014-03-07 22:06:05]

lgtm

https://codereview.chromium.org/191093002/diff/130001/content/child/blink_pla...
File content/child/blink_platform_impl.cc (right):

https://codereview.chromium.org/191093002/diff/130001/content/child/blink_pla...
content/child/blink_platform_impl.cc:366: return
WebString::fromUTF8(GetContentClient()->GetUserAgent());
Ah, OK.

That is what you were trying to say when you were saying that content should
been calling GetContentClient()->GetUserAgent().

Sorry for not getting this earlier :(

https://codereview.chromium.org/191093002/diff/130001/content/test/webkit_sup...
File content/test/webkit_support.cc (left):

https://codereview.chromium.org/191093002/diff/130001/content/test/webkit_sup...
content/test/webkit_support.cc:113:
webkit_glue::SetUserAgent(webkit_glue::BuildUserAgentFromProduct(
this would be my only concern on //content changes as well.

Everything else looks good to me.

[jam, 2014-03-07 23:13:02]

https://codereview.chromium.org/191093002/diff/130001/content/test/webkit_sup...
File content/test/webkit_support.cc (left):

https://codereview.chromium.org/191093002/diff/130001/content/test/webkit_sup...
content/test/webkit_support.cc:114: "DumpRenderTree/0.0.0.0"));
looks like this did break webkit_unit_tests, but the fix was simple. updated

[Ilya Sherman, 2014-03-08 00:03:52]

autofill lgtm

[jam, 2014-03-09 17:49:08]

TBR=mkosiba,jamesr for android_webview and webkit

[mkosiba (inactive), 2014-03-10 11:08:26]

android_webview/ LGTM

[jamesr, 2014-03-10 19:37:31]

lgtm. yay!