chrome/browser/ui/webui/help/help_handler.cc - Issue 191093002: Simplify the user agent code some more since after r255534 it's not affected by the site's URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/help/help_handler.cc

Issue 191093002: Simplify the user agent code some more since after r255534 it's not affected by the site's URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: patchset 15 which works Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/help/help_handler.cc

===================================================================

--- chrome/browser/ui/webui/help/help_handler.cc (revision 255867)

+++ chrome/browser/ui/webui/help/help_handler.cc (working copy)

@@ -21,6 +21,7 @@

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/browser_finder.h"

#include "chrome/browser/ui/chrome_pages.h"

+#include "chrome/common/chrome_content_client.h"

#include "chrome/common/chrome_version_info.h"

#include "chrome/common/pref_names.h"

#include "chrome/common/url_constants.h"

@@ -28,7 +29,6 @@

#include "content/public/browser/notification_service.h"

#include "content/public/browser/web_ui.h"

#include "content/public/browser/web_ui_data_source.h"

-#include "content/public/common/content_client.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

#include "grit/google_chrome_strings.h"

@@ -280,7 +280,7 @@

source->AddString("jsEngine", "V8");

source->AddString("jsEngineVersion", v8::V8::GetVersion());

- source->AddString("userAgentInfo", content::GetUserAgent(GURL()));

+ source->AddString("userAgentInfo", GetUserAgent());

CommandLine::StringType command_line =

CommandLine::ForCurrentProcess()->GetCommandLineString();

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | chrome/browser/ui/webui/version_ui.cc » ('j') | no next file with comments »