Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: chrome/browser/net/chrome_http_user_agent_settings.cc

Issue 191093002: Simplify the user agent code some more since after r255534 it's not affected by the site's URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: patchset 15 which works Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/net/chrome_http_user_agent_settings.h ('k') | chrome/browser/net/preconnect.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/chrome_http_user_agent_settings.h" 5 #include "chrome/browser/net/chrome_http_user_agent_settings.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/common/chrome_content_client.h"
8 #include "chrome/common/pref_names.h" 9 #include "chrome/common/pref_names.h"
9 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
10 #include "content/public/common/content_client.h"
11 #include "net/http/http_util.h" 11 #include "net/http/http_util.h"
12 12
13 ChromeHttpUserAgentSettings::ChromeHttpUserAgentSettings(PrefService* prefs) { 13 ChromeHttpUserAgentSettings::ChromeHttpUserAgentSettings(PrefService* prefs) {
14 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI)); 14 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
15 pref_accept_language_.Init(prefs::kAcceptLanguages, prefs); 15 pref_accept_language_.Init(prefs::kAcceptLanguages, prefs);
16 last_pref_accept_language_ = *pref_accept_language_; 16 last_pref_accept_language_ = *pref_accept_language_;
17 last_http_accept_language_ = 17 last_http_accept_language_ =
18 net::HttpUtil::GenerateAcceptLanguageHeader(last_pref_accept_language_); 18 net::HttpUtil::GenerateAcceptLanguageHeader(last_pref_accept_language_);
19 pref_accept_language_.MoveToThread( 19 pref_accept_language_.MoveToThread(
20 content::BrowserThread::GetMessageLoopProxyForThread( 20 content::BrowserThread::GetMessageLoopProxyForThread(
(...skipping 13 matching lines...) Expand all
34 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO)); 34 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
35 std::string new_pref_accept_language = *pref_accept_language_; 35 std::string new_pref_accept_language = *pref_accept_language_;
36 if (new_pref_accept_language != last_pref_accept_language_) { 36 if (new_pref_accept_language != last_pref_accept_language_) {
37 last_http_accept_language_ = 37 last_http_accept_language_ =
38 net::HttpUtil::GenerateAcceptLanguageHeader(new_pref_accept_language); 38 net::HttpUtil::GenerateAcceptLanguageHeader(new_pref_accept_language);
39 last_pref_accept_language_ = new_pref_accept_language; 39 last_pref_accept_language_ = new_pref_accept_language;
40 } 40 }
41 return last_http_accept_language_; 41 return last_http_accept_language_;
42 } 42 }
43 43
44 std::string ChromeHttpUserAgentSettings::GetUserAgent(const GURL& url) const { 44 std::string ChromeHttpUserAgentSettings::GetUserAgent() const {
45 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO)); 45 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
46 return content::GetUserAgent(url); 46 return ::GetUserAgent();
47 } 47 }
48 48
OLDNEW
« no previous file with comments | « chrome/browser/net/chrome_http_user_agent_settings.h ('k') | chrome/browser/net/preconnect.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698