content/browser/devtools/devtools_http_handler_impl.cc - Issue 191093002: Simplify the user agent code some more since after r255534 it's not affected by the site's URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 191093002: Simplify the user agent code some more since after r255534 it's not affected by the site's URL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: patchset 15 which works Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/devtools_http_handler_impl.cc

===================================================================

--- content/browser/devtools/devtools_http_handler_impl.cc (revision 255867)

+++ content/browser/devtools/devtools_http_handler_impl.cc (working copy)

@@ -37,7 +37,6 @@

#include "net/base/ip_endpoint.h"

#include "net/server/http_server_request_info.h"

#include "net/server/http_server_response_info.h"

-#include "webkit/common/user_agent/user_agent.h"

#include "webkit/common/user_agent/user_agent_util.h"

#if defined(OS_ANDROID)

@@ -454,9 +453,8 @@

base::DictionaryValue version;

version.SetString("Protocol-Version", kProtocolVersion);

version.SetString("WebKit-Version", webkit_glue::GetWebKitVersion());

- version.SetString("Browser", content::GetContentClient()->GetProduct());

- version.SetString("User-Agent",

- webkit_glue::GetUserAgent(GURL(kAboutBlankURL)));

+ version.SetString("Browser", GetContentClient()->GetProduct());

+ version.SetString("User-Agent", GetContentClient()->GetUserAgent());

#if defined(OS_ANDROID)

version.SetString("Android-Package",

base::android::BuildInfo::GetInstance()->package_name());

« no previous file with comments | « content/app/content_main_runner.cc ('k') | content/browser/media/android/browser_media_player_manager.cc » ('j') | no next file with comments »