Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1910723003: Add layout tests for notification icon with redirect loop. (Closed)

Created:
4 years, 8 months ago by Michael van Ouwerkerk
Modified:
4 years, 8 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, blink-reviews, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@NotificationTestsUsePromises
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layout tests for notification icon with redirect loop. BUG=592188 Committed: https://crrev.com/28a768838e7b3c1c9735035b7085610359f749f0 Cr-Commit-Position: refs/heads/master@{#389088}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-redirect-loop.html View 3 chunks +5 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect-loop.html View 4 chunks +5 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/resources/infinite-loop.php View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/XMLHttpRequestException.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/XMLHttpRequestException-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/connection-error-sync.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/connection-error-sync-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/onloadend-event-after-error.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/onloadend-event-after-sync-requests.html View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/infinite-loop.php View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1907443007 Patch 20001

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910723003/1
4 years, 8 months ago (2016-04-21 17:13:13 UTC) #2
Michael van Ouwerkerk
Peter, could you take a look please?
4 years, 8 months ago (2016-04-21 17:13:32 UTC) #4
Peter Beverloo
lgtm, thank you! :)
4 years, 8 months ago (2016-04-21 17:29:06 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-21 18:54:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910723003/20001
4 years, 8 months ago (2016-04-22 12:25:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-22 13:47:12 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:46:45 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/28a768838e7b3c1c9735035b7085610359f749f0
Cr-Commit-Position: refs/heads/master@{#389088}

Powered by Google App Engine
This is Rietveld 408576698