third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect-loop.html - Issue 1910723003: Add layout tests for notification icon with redirect loop.

Unified Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect-loop.html

Issue 1910723003: Add layout tests for notification icon with redirect loop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NotificationTestsUsePromises

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-redirect-loop.html ('k') | third_party/WebKit/LayoutTests/http/tests/resources/infinite-loop.php » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect-loop.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect-loop.html

similarity index 76%

copy from third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html

copy to third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect-loop.html

index 60b8e1e7c9ea0a061ac7382f46c0ceb6ad25f8c7..91e3d36fc6e257ab684a81813807cd211b0ac815 100644

--- a/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-404.html

+++ b/third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect-loop.html

@@ -1,7 +1,7 @@

<!doctype html>

<html>

<head>

- <title>Notifications: Showing a notification with an image that 404s.</title>

+ <title>Notifications: Showing a notification with an image that has a redirect loop still succeeds.</title>

@@ -9,8 +9,7 @@

</head>

<body>

- // Tests that showing a notification with an image that creates a 404 response

- // works properly, and does not block the actual display of it.

+ // Tests that showing a notification with an image that has a redirect loop still succeeds.

async_test(function(test) {

var scope = 'resources/scope/' + location.pathname,

@@ -19,13 +18,13 @@

testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

getActiveServiceWorkerWithMessagePort(test, script, scope).then(function(info) {

// (1) Display a Web Notification through the Service Worker with

- // an image that will trigger a 404 response immediately.

+ // an image that takes redirects to another image.

return sendCommand(info.port, {

command: 'show',

title: 'My Notification',

options: { body: 'Hello, world!',

- icon: '/resources/404image.php' }

+ icon: '/resources/infinite-loop.php' }

});

}).then(function(data) {

// (2) Confirm that the service worker displayed the notification successfully.

@@ -34,7 +33,7 @@

test.done();

}).catch(unreached_rejection(test));

- }, 'Displaying a notification with an image that 404s still resolves the promise.');

+ }, 'Showing a notification with an image that has a redirect loop still succeeds.');

</script>

</body>

</html>