third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-redirect-loop.html - Issue 1910723003: Add layout tests for notification icon with redirect loop.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-image-redirect-loop.html

Issue 1910723003: Add layout tests for notification icon with redirect loop. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NotificationTestsUsePromises

Patch Set: Rebase. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-image-redirect-loop.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Notifications: Showing a notification with an image that 404s.</title >	4 <title>Notifications: Showing a notification with an image that has a redire ct loop still succeeds.</title>

5 <script src="../resources/testharness.js"></script>	5 <script src="../resources/testharness.js"></script>

6 <script src="../resources/testharnessreport.js"></script>	6 <script src="../resources/testharnessreport.js"></script>

7 <script src="../serviceworker/resources/test-helpers.js"></script>	7 <script src="../serviceworker/resources/test-helpers.js"></script>

8 <script src="resources/test-helpers.js"></script>	8 <script src="resources/test-helpers.js"></script>

9 </head>	9 </head>

10 <body>	10 <body>

11 <script>	11 <script>

12 // Tests that showing a notification with an image that creates a 404 resp onse	12 // Tests that showing a notification with an image that has a redirect loo p still succeeds.

13 // works properly, and does not block the actual display of it.

14	13

15 async_test(function(test) {	14 async_test(function(test) {

16 var scope = 'resources/scope/' + location.pathname,	15 var scope = 'resources/scope/' + location.pathname,

17 script = 'instrumentation-service-worker.js';	16 script = 'instrumentation-service-worker.js';

18	17

19 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);	18 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

20 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(info) {	19 getActiveServiceWorkerWithMessagePort(test, script, scope).then(functi on(info) {

21 // (1) Display a Web Notification with an image that 404s.	20 // (1) Display a Web Notification with an image that redirects.

22 return info.registration.showNotification(scope, {	21 return info.registration.showNotification(scope, {

23 body: 'Hello, world!',	22 body: 'Hello, world!',

24 icon: '/resources/404image.php'	23 icon: '/resources/redirectloop.php'

25 });	24 });

26 }).then(function() {	25 }).then(function() {

27 test.done();	26 test.done();

28 }).catch(unreached_rejection(test));	27 }).catch(unreached_rejection(test));

29	28

30 }, 'Displaying a notification with an image that 404s still resolves the p romise.');	29 }, 'Showing a notification with an image that has a redirect loop still su cceeds.');

31 </script>	30 </script>

32 </body>	31 </body>

33 </html>	32 </html>

OLD	NEW