Use promises in notifications tests and enable controlling the page.

Use promises in notifications tests and enable controlling the page.

For Web Notifications layout tests:
* sendCommand returns a promise, sends one command, and waits for a response.
* simulateNotificationClick returns a promise, simulates a click, and waits for a response.
* Make it possible to control the test page when using ./ scope.

Committed: https://crrev.com/9725447a246150f32bf88cfe71eee37ccb91abeb
Cr-Commit-Position: refs/heads/master@{#389069}

[Michael van Ouwerkerk, 2016-04-21 17:05:38]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 17:06:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907443007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907443007/1

[Michael van Ouwerkerk, 2016-04-21 17:06:26]

Description was changed from

==========
Use promises in notifications tests and enable controlling the page.

For Web Notifications layout tests:
* sendCommand returns a promise, sends one command, and waits for a response.
* simulateNotificationClick returns a promise, simulates a click, and waits for
a reponse.
* Make it possible to control the test page.
==========

to

==========
Use promises in notifications tests and enable controlling the page.

For Web Notifications layout tests:
* sendCommand returns a promise, sends one command, and waits for a response.
* simulateNotificationClick returns a promise, simulates a click, and waits for
a response.
* Make it possible to control the test page when using ./ scope.
==========

[Michael van Ouwerkerk, 2016-04-21 17:10:42]

mvanouwerkerk@chromium.org changed reviewers:
+ peter@chromium.org

[Michael van Ouwerkerk, 2016-04-21 17:10:42]

Hi Peter, I heard you like promises...

[Peter Beverloo, 2016-04-21 17:20:56]

lgtm if bots are happy

https://codereview.chromium.org/1907443007/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/1907443007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/instrumentation-service-worker.js:64:
case 'get-fetch-history':
nit: try to scope changes like this to the change where you'll be using them

In this case it's minor, but it's super easy for small bits of logic to just
slip in :)

https://codereview.chromium.org/1907443007/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js
(right):

https://codereview.chromium.org/1907443007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js:79:
reject('Invalid message from the Service Worker.');
nit: Promises should be rejected with errors.

new Error('Invalid message from the Service Worker.')

(Mentally map a rejection handler to the contents of the "catch" in a try {}
catch {}.)

[commit-bot: I haz the power, 2016-04-21 18:17:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 18:17:43]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2016-04-22 09:24:14]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2016-04-22 09:24:15]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1907443007/#ps20001
(title: "Rebase. Address peter's comments.")

[commit-bot: I haz the power, 2016-04-22 09:24:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1907443007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1907443007/20001

[Michael van Ouwerkerk, 2016-04-22 09:44:22]

https://codereview.chromium.org/1907443007/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/instrumentation-service-worker.js
(right):

https://codereview.chromium.org/1907443007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/instrumentation-service-worker.js:64:
case 'get-fetch-history':
On 2016/04/21 17:20:56, Peter Beverloo wrote:
> nit: try to scope changes like this to the change where you'll be using them
> 
> In this case it's minor, but it's super easy for small bits of logic to just
> slip in :)

Acknowledged.

https://codereview.chromium.org/1907443007/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js
(right):

https://codereview.chromium.org/1907443007/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js:79:
reject('Invalid message from the Service Worker.');
On 2016/04/21 17:20:56, Peter Beverloo wrote:
> nit: Promises should be rejected with errors.
> 
> new Error('Invalid message from the Service Worker.')
> 
> (Mentally map a rejection handler to the contents of the "catch" in a try {}
> catch {}.)

Done.

[commit-bot: I haz the power, 2016-04-22 10:55:25]

Description was changed from

==========
Use promises in notifications tests and enable controlling the page.

For Web Notifications layout tests:
* sendCommand returns a promise, sends one command, and waits for a response.
* simulateNotificationClick returns a promise, simulates a click, and waits for
a response.
* Make it possible to control the test page when using ./ scope.
==========

to

==========
Use promises in notifications tests and enable controlling the page.

For Web Notifications layout tests:
* sendCommand returns a promise, sends one command, and waits for a response.
* simulateNotificationClick returns a promise, simulates a click, and waits for
a response.
* Make it possible to control the test page when using ./ scope.
==========

[commit-bot: I haz the power, 2016-04-22 10:55:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:45:58]

Description was changed from

==========
Use promises in notifications tests and enable controlling the page.

For Web Notifications layout tests:
* sendCommand returns a promise, sends one command, and waits for a response.
* simulateNotificationClick returns a promise, simulates a click, and waits for
a response.
* Make it possible to control the test page when using ./ scope.
==========

to

==========
Use promises in notifications tests and enable controlling the page.

For Web Notifications layout tests:
* sendCommand returns a promise, sends one command, and waits for a response.
* simulateNotificationClick returns a promise, simulates a click, and waits for
a response.
* Make it possible to control the test page when using ./ scope.

Committed: https://crrev.com/9725447a246150f32bf88cfe71eee37ccb91abeb
Cr-Commit-Position: refs/heads/master@{#389069}
==========

[commit-bot: I haz the power, 2016-04-22 19:45:59]

Patchset 2 (id:??) landed as
https://crrev.com/9725447a246150f32bf88cfe71eee37ccb91abeb
Cr-Commit-Position: refs/heads/master@{#389069}