[css-grid] Fix bug with positioned items in vertical writing mode

[css-grid] Fix bug with positioned items in vertical writing mode

In LayoutGrid::offsetAndBreadthForPositionedChild() we were using directly
borderLeft(), which is wrong in vertical writing modes.

To fix it we just need to use borderLogicalLeft() which is aware of
the current writing mode.

Modified current test to add borders and cases for positioned items
with offsets.

BUG=273898
TEST=fast/css-grid-layout/grid-positioned-children-writing-modes.html

Committed: https://crrev.com/e070cb32423f6603b23a62e3b879f363f79bff69
Cr-Commit-Position: refs/heads/master@{#389068}

[Manuel Rego, 2016-04-21 20:56:13]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jfernandez@igalia.com, svillar@igalia.com

[svillar, 2016-04-22 08:17:21]

lgtm

https://codereview.chromium.org/1909153002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html
(right):

https://codereview.chromium.org/1909153002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html:75:
<div class="sizedToGridArea red"></div>
Do you need all the sizedToGridArea ?

[Manuel Rego, 2016-04-22 08:43:57]

Thanks for the review.

https://codereview.chromium.org/1909153002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html
(right):

https://codereview.chromium.org/1909153002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html:75:
<div class="sizedToGridArea red"></div>
On 2016/04/22 08:17:21, svillar wrote:
> Do you need all the sizedToGridArea ?

Nope as it stretches by default, I've just removed it.

[Manuel Rego, 2016-04-22 08:44:05]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-04-22 08:44:06]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com
Link to the patchset: https://codereview.chromium.org/1909153002/#ps20001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-04-22 08:44:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909153002/20001

[Manuel Rego, 2016-04-22 09:14:58]

The CQ bit was unchecked by rego@igalia.com

[Manuel Rego, 2016-04-22 09:50:09]

The CQ bit was checked by rego@igalia.com

[Manuel Rego, 2016-04-22 09:50:10]

The patchset sent to the CQ was uploaded after l-g-t-m from svillar@igalia.com
Link to the patchset: https://codereview.chromium.org/1909153002/#ps40001
(title: "Increase size of grids in the tests to avoid weird visual results")

[commit-bot: I haz the power, 2016-04-22 09:50:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909153002/40001

[commit-bot: I haz the power, 2016-04-22 10:54:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:45:55]

Description was changed from

==========
[css-grid] Fix bug with positioned items in vertical writing mode

In LayoutGrid::offsetAndBreadthForPositionedChild() we were using directly
borderLeft(), which is wrong in vertical writing modes.

To fix it we just need to use borderLogicalLeft() which is aware of
the current writing mode.

Modified current test to add borders and cases for positioned items
with offsets.

BUG=273898
TEST=fast/css-grid-layout/grid-positioned-children-writing-modes.html
==========

to

==========
[css-grid] Fix bug with positioned items in vertical writing mode

In LayoutGrid::offsetAndBreadthForPositionedChild() we were using directly
borderLeft(), which is wrong in vertical writing modes.

To fix it we just need to use borderLogicalLeft() which is aware of
the current writing mode.

Modified current test to add borders and cases for positioned items
with offsets.

BUG=273898
TEST=fast/css-grid-layout/grid-positioned-children-writing-modes.html

Committed: https://crrev.com/e070cb32423f6603b23a62e3b879f363f79bff69
Cr-Commit-Position: refs/heads/master@{#389068}
==========

[commit-bot: I haz the power, 2016-04-22 19:45:56]

Patchset 3 (id:??) landed as
https://crrev.com/e070cb32423f6603b23a62e3b879f363f79bff69
Cr-Commit-Position: refs/heads/master@{#389068}

[cbiesinger, 2016-04-22 20:03:16]

lgtm