Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html

Issue 1909153002: [css-grid] Fix bug with positioned items in vertical writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Increase size of grids in the tests to avoid weird visual results Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html
index 88a45d568a5e5c7c5445f418695e910e1db1b2b4..652f09510e1061be08d44aaa1f7c87c67c2e1140 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes.html
@@ -4,11 +4,14 @@
<style>
.grid {
- margin: 1px;
- width: 50px;
- height: 25px;
- grid: 100% / 100%;
+ margin: 5px;
+ width: 100px;
+ height: 75px;
+ grid: 20px / 30px;
padding: 5px 10px 15px 20px;
+ border-style: solid;
+ border-width: 5px 10px 15px 20px;
+ float: left;
/* Ensures that the grid container is the containing block of the grid children. */
position: relative;
}
@@ -23,49 +26,80 @@
grid-row: 1 / 2;
}
+.offsets {
+ left: 0;
+ top: 0;
+}
+
.red {
background-color: red;
- width: 50px;
- height: 25px;
- top: 5px;
- left: 20px;
}
</style>
<body>
<p>This test checks the behavior of the positioned grid children in combination with the writing modes and text direction properties.</p>
-<p>For the test to pass you should see no red and all the green boxes should have the very the same position and size within each grey box. The black box will be positioned depending on the writing mode and text direction values.</p>
+<p>For the test to pass you should see no red and only green boxes. The black box will be positioned depending on the writing mode and text direction values.</p>
<div class="grid">
- <div class="sizedToGridArea red"></div>
+ <div class="red"></div>
<div class="sizedToGridArea absolute onlyFirstRowOnlyFirstColumn">XX</div>
</div>
<div class="grid verticalRL">
- <div class="sizedToGridArea red"></div>
+ <div class="red"></div>
<div class="sizedToGridArea absolute onlyFirstRowOnlyFirstColumn">XX</div>
</div>
<div class="grid verticalLR">
- <div class="sizedToGridArea red"></div>
+ <div class="red"></div>
<div class="sizedToGridArea absolute onlyFirstRowOnlyFirstColumn">XX</div>
</div>
<div class="grid directionRTL">
- <div class="sizedToGridArea red"></div>
+ <div class="red"></div>
<div class="sizedToGridArea absolute onlyFirstRowOnlyFirstColumn">XX</div>
</div>
<div class="grid verticalRL directionRTL">
- <div class="sizedToGridArea red"></div>
+ <div class="red"></div>
<div class="sizedToGridArea absolute onlyFirstRowOnlyFirstColumn">XX</div>
</div>
<div class="grid verticalLR directionRTL">
- <div class="sizedToGridArea red"></div>
+ <div class="red"></div>
<div class="sizedToGridArea absolute onlyFirstRowOnlyFirstColumn">XX</div>
</div>
+<div class="grid">
+ <div class="red"></div>
+ <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div>
+</div>
+
+<div class="grid verticalRL">
+ <div class="red"></div>
+ <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div>
+</div>
+
+<div class="grid verticalLR">
+ <div class="red"></div>
+ <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div>
+</div>
+
+<div class="grid directionRTL">
+ <div class="red"></div>
+ <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div>
+</div>
+
+<div class="grid verticalRL directionRTL">
+ <div class="red"></div>
+ <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div>
+</div>
+
+<div class="grid verticalLR directionRTL">
+ <div class="red"></div>
+ <div class="sizedToGridArea absolute offsets onlyFirstRowOnlyFirstColumn">XX</div>
+</div>
+
</body>
</html>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698