Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html

Issue 1909153002: [css-grid] Fix bug with positioned items in vertical writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Increase size of grids in the tests to avoid weird visual results Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html
index e0c8f676f65ed9c3e3a58cc3feba896aaecfb820..ce58ab0f1891adaa50f235875a107c36e28e2262 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html
@@ -5,44 +5,79 @@
.grid {
display: block;
- margin: 1px;
- width: 50px;
- height: 25px;
+ margin: 5px;
+ width: 100px;
+ height: 75px;
padding: 5px 10px 15px 20px;
+ border-style: solid;
+ border-width: 5px 10px 15px 20px;
+ float: left;
}
.green {
background-color: green;
+ width: 30px;
+ height: 20px;
+ font: 10px/1 Ahem;
+}
+
+.verticalSize {
+ width: 20px;
+ height: 30px;
}
</style>
<body>
<p>This test checks the behavior of the positioned grid children in combination with the writing modes and text direction properties.</p>
-<p>For the test to pass you should see no red and all the green boxes should have the very the same position and size within each grey box. The black box will be positioned depending on the writing mode and text direction values.</p>
+<p>For the test to pass you should see no red and only green boxes. The black box will be positioned depending on the writing mode and text direction values.</p>
+
+<div class="grid">
+ <div class="green">XX</div>
+</div>
+
+<div class="grid verticalRL">
+ <div class="green verticalSize">XX</div>
+</div>
+
+<div class="grid verticalLR">
+ <div class="green verticalSize">XX</div>
+</div>
+
+<div class="grid directionRTL">
+ <div class="green">XX</div>
+</div>
+
+<div class="grid verticalRL directionRTL">
+ <div class="green verticalSize">XX</div>
+</div>
+
+<div class="grid verticalLR directionRTL">
+ <div class="green verticalSize">XX</div>
+</div>
<div class="grid">
- <div class="sizedToGridArea green">XX</div>
+ <div class="green">XX</div>
</div>
<div class="grid verticalRL">
- <div class="sizedToGridArea green">XX</div>
+ <div class="green verticalSize">XX</div>
</div>
<div class="grid verticalLR">
- <div class="sizedToGridArea green">XX</div>
+ <div class="green verticalSize">XX</div>
</div>
<div class="grid directionRTL">
- <div class="sizedToGridArea green">XX</div>
+ <div class="green">XX</div>
</div>
<div class="grid verticalRL directionRTL">
- <div class="sizedToGridArea green">XX</div>
+ <div class="green verticalSize">XX</div>
</div>
<div class="grid verticalLR directionRTL">
- <div class="sizedToGridArea green">XX</div>
+ <div class="green verticalSize">XX</div>
</div>
</body>

Powered by Google App Engine
This is Rietveld 408576698