third_party/WebKit/Source/core/layout/LayoutGrid.cpp - Issue 1909153002: [css-grid] Fix bug with positioned items in vertical writing mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 1909153002: [css-grid] Fix bug with positioned items in vertical writing mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Increase size of grids in the tests to avoid weird visual results Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

index d21c92d9d816e34825343fd8774b4251f2f6c078..590c8498690b30fafd07e17796589f4f58e14e2a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp

@@ -1632,7 +1632,7 @@ void LayoutGrid::offsetAndBreadthForPositionedChild(const LayoutBox& child, Grid

if (endIsAuto) {

offset = LayoutUnit();

} else {

- offset = translateRTLCoordinate(m_columnPositions[endLine]) - borderLeft();

+ offset = translateRTLCoordinate(m_columnPositions[endLine]) - borderLogicalLeft();

if (endLine > firstExplicitLine && endLine < lastExplicitLine) {

offset += guttersSize(direction, 2);

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-positioned-children-writing-modes-expected.html ('k') | no next file » | no next file with comments »