Tests that notification resource requests are handled by onfetch.

Tests that notification resource requests are handled by onfetch.

BUG=592188, 605917
Committed: https://crrev.com/c14267b65adf1fc1f1c7eebfd55355fc131b7acb
Cr-Commit-Position: refs/heads/master@{#389102}

[Michael van Ouwerkerk, 2016-04-21 17:15:15]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 17:15:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909043003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909043003/1

[Michael van Ouwerkerk, 2016-04-21 17:16:50]

mvanouwerkerk@chromium.org changed reviewers:
+ peter@chromium.org

[Michael van Ouwerkerk, 2016-04-21 17:16:50]

Peter, could you take a look please?

[Peter Beverloo, 2016-04-21 17:27:00]

lgtm, thank you!

Please extrapolate the comments on
serviceworkerregistration-document-fetch-resources.html to the other tests where
applicable.

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js
(right):

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js:105:
function listenOnce(target, type)
++docs

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html
(right):

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html:12:
// Tests that the request for the notification icon is handled by the fetch
event handler.
nit: + "for a persistent notifications shown by the document" because of it's
significance?

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html:14:
async_test(test => {
Consider using promise_test()?

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html:25:
registration = info.registration;
nit: unnecessary

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html:33:
assert_equals(data.fetchHistory[0], location.origin + iconPath);
assert_equals(data.fetchHistory.length, 1); ?

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources.html
(right):

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources.html:38:
// TODO(mvanouwerkerk): The fetch should go through the service worker.
++bug reference?

[commit-bot: I haz the power, 2016-04-21 18:32:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 18:32:43]

Dry run: This issue passed the CQ dry run.

[Michael van Ouwerkerk, 2016-04-22 13:21:06]

Description was changed from

==========
Tests that notification resource requests are handled by onfetch.

BUG=592188
==========

to

==========
Tests that notification resource requests are handled by onfetch.

BUG=592188,605917
==========

[Michael van Ouwerkerk, 2016-04-22 13:23:54]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2016-04-22 13:23:55]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1909043003/#ps40001
(title: "Delete unused variable.")

[commit-bot: I haz the power, 2016-04-22 13:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909043003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909043003/40001

[Michael van Ouwerkerk, 2016-04-22 13:24:09]

Thanks Peter.

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js
(right):

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js:105:
function listenOnce(target, type)
On 2016/04/21 17:27:00, Peter Beverloo wrote:
> ++docs

Done.

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html
(right):

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html:12:
// Tests that the request for the notification icon is handled by the fetch
event handler.
On 2016/04/21 17:27:00, Peter Beverloo wrote:
> nit: + "for a persistent notifications shown by the document" because of it's
> significance?

Done.

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html:14:
async_test(test => {
On 2016/04/21 17:27:00, Peter Beverloo wrote:
> Consider using promise_test()?

Done.

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html:25:
registration = info.registration;
On 2016/04/21 17:27:00, Peter Beverloo wrote:
> nit: unnecessary

Done.

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html:33:
assert_equals(data.fetchHistory[0], location.origin + iconPath);
On 2016/04/21 17:27:00, Peter Beverloo wrote:
> assert_equals(data.fetchHistory.length, 1); ?

Done.

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources.html
(right):

https://codereview.chromium.org/1909043003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources.html:38:
// TODO(mvanouwerkerk): The fetch should go through the service worker.
On 2016/04/21 17:27:00, Peter Beverloo wrote:
> ++bug reference?

Done.

[commit-bot: I haz the power, 2016-04-22 14:40:04]

Description was changed from

==========
Tests that notification resource requests are handled by onfetch.

BUG=592188,605917
==========

to

==========
Tests that notification resource requests are handled by onfetch.

BUG=592188,605917
==========

[commit-bot: I haz the power, 2016-04-22 14:40:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:47:17]

Description was changed from

==========
Tests that notification resource requests are handled by onfetch.

BUG=592188,605917
==========

to

==========
Tests that notification resource requests are handled by onfetch.

BUG=592188,605917

Committed: https://crrev.com/c14267b65adf1fc1f1c7eebfd55355fc131b7acb
Cr-Commit-Position: refs/heads/master@{#389102}
==========

[commit-bot: I haz the power, 2016-04-22 19:47:18]

Patchset 3 (id:??) landed as
https://crrev.com/c14267b65adf1fc1f1c7eebfd55355fc131b7acb
Cr-Commit-Position: refs/heads/master@{#389102}