third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html - Issue 1909043003: Tests that notification resource requests are handled by onfetch.

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html

Issue 1909043003: Tests that notification resource requests are handled by onfetch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NotificationTestsUsePromises

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js ('K') | « third_party/WebKit/LayoutTests/http/tests/notifications/resources/test-helpers.js ('k') | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-page-notification-fetch-resources.html » ('j') | third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>Notifications: the fetch handler handles the request for the icon.</t itle>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="../serviceworker/resources/test-helpers.js"></script>

	8 <script src="resources/test-helpers.js"></script>

	9 </head>

	10 <body>

	11 <script>

	12 // Tests that the request for the notification icon is handled by the fetc h event handler.
	Peter Beverloo 2016/04/21 17:27:00 nit: + "for a persistent notifications shown by th nit: + "for a persistent notifications shown by the document" because of it's significance? Michael van Ouwerkerk 2016/04/22 13:24:09 Done. Show quoted text On 2016/04/21 17:27:00, Peter Beverloo wrote: > nit: + "for a persistent notifications shown by the document" because of it's > significance? Done.
	13

	14 async_test(test => {
	Peter Beverloo 2016/04/21 17:27:00 Consider using promise_test()? Consider using promise_test()? Michael van Ouwerkerk 2016/04/22 13:24:09 Done. Show quoted text On 2016/04/21 17:27:00, Peter Beverloo wrote: > Consider using promise_test()? Done.
	15 var scope = './';

	16 var script = 'instrumentation-service-worker.js';

	17 var port;

	18 var registration;

	19 var iconPath = '/resources/square20.png';

	20

	21 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

	22

	23 getActiveServiceWorkerWithMessagePort(test, script, scope).then(info = > {

	24 port = info.port;

	25 registration = info.registration;
	Peter Beverloo 2016/04/21 17:27:00 nit: unnecessary nit: unnecessary Michael van Ouwerkerk 2016/04/22 13:24:09 Done. Show quoted text On 2016/04/21 17:27:00, Peter Beverloo wrote: > nit: unnecessary Done.
	26 assert_true(!!navigator.serviceWorker.controller, 'The page must b e controlled.');

	27 // (1) Display a persistent notification from a document context.

	28 return registration.showNotification('Title', { icon: iconPath });

	29 }).then(() => {

	30 return sendCommand(port, { command: 'get-fetch-history' });

	31 }).then(data => {

	32 // (2) Confirm that the icon request passed through the fetch even t handler.

	33 assert_equals(data.fetchHistory[0], location.origin + iconPath);
	Peter Beverloo 2016/04/21 17:27:00 assert_equals(data.fetchHistory.length, 1); ? assert_equals(data.fetchHistory.length, 1); ? Michael van Ouwerkerk 2016/04/22 13:24:09 Done. Show quoted text On 2016/04/21 17:27:00, Peter Beverloo wrote: > assert_equals(data.fetchHistory.length, 1); ? Done.
	34 test.done();

	35 }).catch(unreached_rejection(test));

	36

	37 }, 'The request for the notification icon is handled by the fetch event ha ndler.');

	38 </script>

	39 </body>

	40 </html>

OLD	NEW