third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources.html - Issue 1909043003: Tests that notification resource requests are handled by onfetch.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-service-worker-fetch-resources.html

Issue 1909043003: Tests that notification resource requests are handled by onfetch. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@NotificationTestsUsePromises

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-document-fetch-resources.html ('K') | « third_party/WebKit/LayoutTests/http/tests/notifications/serviceworkerregistration-page-notification-fetch-resources.html ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <html>

	3 <head>

	4 <title>Notifications: the fetch handler handles the request for the icon.</t itle>

	5 <script src="../resources/testharness.js"></script>

	6 <script src="../resources/testharnessreport.js"></script>

	7 <script src="../serviceworker/resources/test-helpers.js"></script>

	8 <script src="resources/test-helpers.js"></script>

	9 </head>

	10 <body>

	11 <script>

	12 // Tests that the request for the notification icon is handled by the fetc h event handler.

	13

	14 async_test(test => {

	15 var scope = './';

	16 var script = 'instrumentation-service-worker.js';

	17 var port;

	18 var registration;

	19 var iconPath = '/resources/square20.png';

	20

	21 testRunner.setPermission('notifications', 'granted', location.origin, location.origin);

	22

	23 getActiveServiceWorkerWithMessagePort(test, script, scope).then(info = > {

	24 port = info.port;

	25 registration = info.registration;

	26 assert_true(!!navigator.serviceWorker.controller, 'The page must b e controlled.');

	27 // (1) Display a persistent notification from a service worker con text.

	28 return sendCommand(port, {

	29 command: 'show',

	30 title: 'Title',

	31 options: { icon: iconPath }

	32 });

	33 }).then(data => {

	34 assert_true(data.success);

	35 return sendCommand(port, { command: 'get-fetch-history' });

	36 }).then(data => {

	37 // (2) Verify that the icon request passed through the fetch event handler.

	38 // TODO(mvanouwerkerk): The fetch should go through the service wo rker.
	Peter Beverloo 2016/04/21 17:27:00 ++bug reference? ++bug reference? Michael van Ouwerkerk 2016/04/22 13:24:09 Done. Show quoted text On 2016/04/21 17:27:00, Peter Beverloo wrote: > ++bug reference? Done.
	39 assert_equals(data.fetchHistory.length, 0);

	40 test.done();

	41 }).catch(unreached_rejection(test));

	42

	43 }, 'The request for the notification icon is handled by the fetch event ha ndler.');

	44 </script>

	45 </body>

	46 </html>

OLD	NEW