Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1908683002: Replace OS_LEFT/RIGHT with META_LEFT/RIGHT (Closed)

Created:
4 years, 8 months ago by dtapuska
Modified:
4 years, 8 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, jam, kalyank, oshima+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace OS_LEFT/RIGHT with META_LEFT/RIGHT The DOM Code specification changed so ensure we send the correct names for the Meta keys. This change was done via git grep | sed. BUG=602885 Committed: https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d Cr-Commit-Position: refs/heads/master@{#388764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -123 lines) Patch
M chrome/browser/chromeos/events/event_rewriter.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 22 chunks +34 lines, -34 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/normalizing_input_filter_cros.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/normalizing_input_filter_cros_unittest.cc View 7 chunks +28 lines, -28 lines 0 comments Download
M remoting/client/normalizing_input_filter_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/normalizing_input_filter_mac_unittest.cc View 5 chunks +30 lines, -30 lines 0 comments Download
M remoting/host/input_injector_x11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/protocol/input_event_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/keycodes/dom/keycode_converter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/keycodes/dom/keycode_converter_data.inc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/keycodes/dom_us_layout_data.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/events/keycodes/keyboard_code_conversion.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/keycodes/keyboard_code_conversion_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
dtapuska
4 years, 8 months ago (2016-04-20 21:14:27 UTC) #3
Wez
lgtm
4 years, 8 months ago (2016-04-20 21:31:46 UTC) #4
kpschoedel
LGTM for ozone.
4 years, 8 months ago (2016-04-20 21:33:08 UTC) #5
Bernhard Bauer
Am I on this review as an OWNER of blocked_content/? If so, that part LGTM ...
4 years, 8 months ago (2016-04-21 08:49:43 UTC) #6
Paweł Hajdan Jr.
content/public/test LGTM
4 years, 8 months ago (2016-04-21 11:38:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908683002/1
4 years, 8 months ago (2016-04-21 13:24:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 14:34:12 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:34:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af863af3e83fae3718ffd0f4340eb1827b9ec15d
Cr-Commit-Position: refs/heads/master@{#388764}

Powered by Google App Engine
This is Rietveld 408576698