remoting/client/normalizing_input_filter_mac.cc - Issue 1908683002: Replace OS_LEFT/RIGHT with META_LEFT/RIGHT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/normalizing_input_filter_mac.cc

Issue 1908683002: Replace OS_LEFT/RIGHT with META_LEFT/RIGHT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/client/normalizing_input_filter_mac.cc

diff --git a/remoting/client/normalizing_input_filter_mac.cc b/remoting/client/normalizing_input_filter_mac.cc

index 5d081fa6d06d9005c580c96da9424f68097512d4..0b0507f3327d2857833d5faa3cbfe1b8d9aaa540 100644

--- a/remoting/client/normalizing_input_filter_mac.cc

+++ b/remoting/client/normalizing_input_filter_mac.cc

@@ -36,8 +36,8 @@ void NormalizingInputFilterMac::InjectKeyEvent(const protocol::KeyEvent& event)

dom_code == ui::DomCode::TAB;

bool is_cmd_key =

- dom_code == ui::DomCode::OS_LEFT ||

- dom_code == ui::DomCode::OS_RIGHT;

+ dom_code == ui::DomCode::META_LEFT ||

+ dom_code == ui::DomCode::META_RIGHT;

if (dom_code == ui::DomCode::CAPS_LOCK) {

// Mac OS X generates keydown/keyup on lock-state transitions, rather than