ui/events/keycodes/dom/keycode_converter.cc - Issue 1908683002: Replace OS_LEFT/RIGHT with META_LEFT/RIGHT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/dom/keycode_converter.cc

Issue 1908683002: Replace OS_LEFT/RIGHT with META_LEFT/RIGHT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/keycodes/dom/keycode_converter.cc

diff --git a/ui/events/keycodes/dom/keycode_converter.cc b/ui/events/keycodes/dom/keycode_converter.cc

index 4531acd128aca240e3f3c5298067bd14d33cf101..94792e57bbcbba03e5a944a714b2fe53e04af6e1 100644

--- a/ui/events/keycodes/dom/keycode_converter.cc

+++ b/ui/events/keycodes/dom/keycode_converter.cc

@@ -125,11 +125,11 @@ DomKeyLocation KeycodeConverter::DomCodeToLocation(DomCode dom_code) {

} kLocations[] = {{DomCode::CONTROL_LEFT, DomKeyLocation::LEFT},

{DomCode::SHIFT_LEFT, DomKeyLocation::LEFT},

{DomCode::ALT_LEFT, DomKeyLocation::LEFT},

- {DomCode::OS_LEFT, DomKeyLocation::LEFT},

+ {DomCode::META_LEFT, DomKeyLocation::LEFT},

{DomCode::CONTROL_RIGHT, DomKeyLocation::RIGHT},

{DomCode::SHIFT_RIGHT, DomKeyLocation::RIGHT},

{DomCode::ALT_RIGHT, DomKeyLocation::RIGHT},

- {DomCode::OS_RIGHT, DomKeyLocation::RIGHT},

+ {DomCode::META_RIGHT, DomKeyLocation::RIGHT},

{DomCode::NUMPAD_DIVIDE, DomKeyLocation::NUMPAD},

{DomCode::NUMPAD_MULTIPLY, DomKeyLocation::NUMPAD},

{DomCode::NUMPAD_SUBTRACT, DomKeyLocation::NUMPAD},