ui/events/keycodes/keyboard_code_conversion_unittest.cc - Issue 1908683002: Replace OS_LEFT/RIGHT with META_LEFT/RIGHT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/keyboard_code_conversion_unittest.cc

Issue 1908683002: Replace OS_LEFT/RIGHT with META_LEFT/RIGHT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/keycodes/keyboard_code_conversion_unittest.cc

diff --git a/ui/events/keycodes/keyboard_code_conversion_unittest.cc b/ui/events/keycodes/keyboard_code_conversion_unittest.cc

index 92540fa16112db77aadf2836526ea3a06111e19d..1fec4ed44b284c6073c4c83978dd1a01ab2d0a0a 100644

--- a/ui/events/keycodes/keyboard_code_conversion_unittest.cc

+++ b/ui/events/keycodes/keyboard_code_conversion_unittest.cc

@@ -245,10 +245,10 @@ TEST(KeyboardCodeConversion, ControlCharacters) {

{ui::DomCode::ALT_RIGHT,

{true, ui::DomKey::ALT, ui::VKEY_MENU},

{true, ui::DomKey::ALT, ui::VKEY_MENU}},

- {ui::DomCode::OS_LEFT,

+ {ui::DomCode::META_LEFT,

{true, ui::DomKey::META, ui::VKEY_LWIN},

{true, ui::DomKey::META, ui::VKEY_LWIN}},

- {ui::DomCode::OS_RIGHT,

+ {ui::DomCode::META_RIGHT,

{true, ui::DomKey::META, ui::VKEY_LWIN},

{true, ui::DomKey::META, ui::VKEY_LWIN}},

{ui::DomCode::DIGIT1,