Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1908463002: Modernize fast/hidpi layout tests (Closed)

Created:
4 years, 8 months ago by davve
Modified:
4 years, 8 months ago
Reviewers:
Yoav Weiss
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modernize fast/hidpi layout tests * Add <!DOCTYPE html> to all tests. None of them seem to test quirk-mode specific issues. * Remove unnecessary <html>, <head> and <body> tags. * 4 space indentation. * Remove stale FIXME. * Drop </img> tags. <img> is a void element. BUG=605065 Committed: https://crrev.com/5a381e720dc5d2b5e7a511057ee75802f92b37ce Cr-Commit-Position: refs/heads/master@{#389730}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Drop </img> from tests. <img> is a void element. #

Patch Set 3 : Add NeedsManualRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+649 lines, -1178 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/border-background-align.html View 1 chunk +20 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/border-background-align-expected.html View 1 chunk +19 lines, -31 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html View 1 1 chunk +12 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/broken-image-with-size-hidpi.html View 1 1 chunk +12 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/clip-text-in-hidpi.html View 1 chunk +7 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/device-scale-factor-paint.html View 1 chunk +6 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/dpr-setting.html View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/focus-rings.html View 1 chunk +7 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/gradient-with-scaled-ancestor.html View 1 chunk +12 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-as-background.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-as-background-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-as-background-with-zoom.html View 2 chunks +5 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-background-dynamic.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-background-dynamic-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-background-repeat.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-background-repeat-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-background-repeat-without-size.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-background-repeat-without-size-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-comparison.html View 1 chunk +26 lines, -32 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-comparison-expected.html View 1 chunk +29 lines, -35 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-dynamic.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-dynamic-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-simple.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-border-image-simple-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-in-content-dynamic.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-in-content-dynamic-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-list-style-image.html View 1 chunk +7 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-list-style-image-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-out-of-order.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-out-of-order-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-shape-outside.html View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-shape-outside-expected.html View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-simple.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-simple-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-without-specified-width.html View 1 chunk +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-set-without-specified-width-expected.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-1x.html View 3 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-change-dynamically-from-js-2x.html View 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-change-dynamically-src-first-2x.html View 3 chunks +4 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-change-resource-dpr.html View 2 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-data-src.html View 1 chunk +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-data-srcset.html View 1 chunk +6 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-density-and-width-descriptors.html View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-dpr-zoom.html View 2 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-fraction.html View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-ignore-double-descriptor.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-intrinsic-size.html View 2 chunks +13 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-intrinsic-size-zero.html View 2 chunks +4 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html View 2 chunks +14 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs.html View 1 1 chunk +3 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-invalid-inputs-except-one.html View 1 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-nomodifier.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-only-src-attribute.html View 1 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-1.html View 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-1-expected.html View 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-2.html View 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-2-expected.html View 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-3.html View 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-3-expected.html View 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-4.html View 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-4-expected.html View 1 chunk +7 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-canvas.html View 1 chunk +17 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-png-canvas-expected.html View 1 chunk +18 lines, -24 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-relative-svg.html View 1 chunk +11 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas.html View 1 chunk +13 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x.html View 1 chunk +13 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html View 1 chunk +14 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-relative-svg-canvas-expected.html View 1 chunk +14 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-relative-svg-expected.html View 1 chunk +11 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-remove-dynamically-from-js.html View 3 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-same-alternative-for-both-attributes.html View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-simple-1x.html View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-simple-2x.html View 2 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-src-selection-1x.html View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-src-selection-1x-both.html View 2 chunks +4 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-src-selection-2x.html View 2 chunks +3 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-svg.html View 1 chunk +11 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-svg-canvas.html View 1 chunk +13 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-svg-canvas-2x.html View 1 chunk +13 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-svg-canvas-2x-expected.html View 1 chunk +14 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-svg-canvas-expected.html View 1 chunk +14 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-svg-expected.html View 1 chunk +11 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-svg2.html View 1 chunk +11 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/image-srcset-svg2-expected.html View 1 chunk +11 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/media-query-as-background-with-zoom.html View 1 chunk +16 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/resize-corner-hidpi.html View 1 2 1 chunk +12 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/hidpi/video-controls-in-hidpi.html View 1 chunk +8 lines, -15 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
davve
The rebaseline bot is offline, so I'm not sure I'll land this now but would ...
4 years, 8 months ago (2016-04-20 13:01:55 UTC) #2
Yoav Weiss
LGTM That's a lot of mechanical changes... :) https://codereview.chromium.org/1908463002/diff/1/third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html File third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html (right): https://codereview.chromium.org/1908463002/diff/1/third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html#newcode3 third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html:3: <img ...
4 years, 8 months ago (2016-04-20 13:36:13 UTC) #3
davve
https://codereview.chromium.org/1908463002/diff/1/third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html File third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html (right): https://codereview.chromium.org/1908463002/diff/1/third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html#newcode3 third_party/WebKit/LayoutTests/fast/hidpi/broken-image-icon-hidpi.html:3: <img src="not-there.png"></img> On 2016/04/20 13:36:13, Yoav Weiss wrote: > ...
4 years, 8 months ago (2016-04-21 08:58:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908463002/20001
4 years, 8 months ago (2016-04-21 09:22:11 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/162570) linux_chromium_compile_dbg_ng on ...
4 years, 8 months ago (2016-04-21 09:27:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908463002/40001
4 years, 8 months ago (2016-04-25 15:11:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/127084)
4 years, 8 months ago (2016-04-25 15:21:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1908463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1908463002/40001
4 years, 8 months ago (2016-04-26 09:18:33 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-26 09:27:32 UTC) #18
commit-bot: I haz the power
4 years, 8 months ago (2016-04-26 09:28:25 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5a381e720dc5d2b5e7a511057ee75802f92b37ce
Cr-Commit-Position: refs/heads/master@{#389730}

Powered by Google App Engine
This is Rietveld 408576698